GH-45926: [Python] Use pytest.approx for float values on unbiased skew and kurtosis tests #45929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed skew and kurtosis tests
Member
Author
|
@github-actions crossbow submit test-debian-12-python-3-i386 |
|
|
github-actions
bot
added
Component: Python
awaiting committer review
|
Revision: ae91842 Submitted crossbow builds: ursacomputing/crossbow @ actions-8f114e6a38
|
pitrou
approved these changes
Mar 25, 2025
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ed4cee0. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Apr 15, 2025
…ed skew and kurtosis tests (apache#45929) ### Rationale for this change The test fails on test-debian-12-python-3-i386 due to accuracy ### What changes are included in this PR? Use pytest.approx instead of hardcoded float value ### Are these changes tested? Yes via CI ### Are there any user-facing changes? No * GitHub Issue: apache#45926 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The test fails on test-debian-12-python-3-i386 due to accuracy
What changes are included in this PR?
Use pytest.approx instead of hardcoded float value
Are these changes tested?
Yes via CI
Are there any user-facing changes?
No