Repository navigation
GH-45510: [CI][C++] Fix LLVM APT repository preparation on Debian - #45511
Conversation
|
@github-actions crossbow submit test-debian-12-* |
|
|
|
Revision: 23cac6e Submitted crossbow builds: ursacomputing/crossbow @ actions-81ac5f56f9
|
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
The failure on debian-12-docs doesn't seem related to this change:
2025-02-12T08:43:06.1451336Z -- Unable to find cuda_runtime.h in "/usr/lib/include" for CUDAToolkit_INCLUDE_DIR.
2025-02-12T08:43:06.1452770Z -- Unable to find cublas_v2.h in either "" or "/math_libs/include"
2025-02-12T08:43:06.1476771Z CMake Error at /usr/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
2025-02-12T08:43:06.1477685Z Could NOT find CUDAToolkit (missing: CUDAToolkit_INCLUDE_DIR) (found
2025-02-12T08:43:06.1478231Z version "11.8.89")
2025-02-12T08:43:06.1478583Z Call Stack (most recent call first):
2025-02-12T08:43:06.1479324Z /usr/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
2025-02-12T08:43:06.1480405Z /usr/share/cmake-3.25/Modules/FindCUDAToolkit.cmake:869 (find_package_handle_standard_args)
2025-02-12T08:43:06.1481189Z src/arrow/gpu/CMakeLists.txt:44 (find_package)
I can see nvidia-cuda-toolkit being installed successfully. We probably want to open that as a separate issue and merge this.
|
It makes sense. Let's do it. |
|
ok, I've opened the issue mentioned above. I am merging this. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c2432af. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
The existing LLVM APT repository preparation is broken. For example, it uses unavailable
${available_llvm}.What changes are included in this PR?
.ascfor armored keyAre these changes tested?
Yes.
Are there any user-facing changes?
No.