ARROW-5531: [Python] Implement Array.from_buffers for varbinary and nested types, add DataType.num_buffers property#4537
Closed
wesm wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-5531: [Python] Implement Array.from_buffers for varbinary and nested types, add DataType.num_buffers property#4537wesm wants to merge 2 commits intoapache:masterfrom
wesm wants to merge 2 commits intoapache:masterfrom
Conversation
pitrou
requested changes
Jun 13, 2019
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
LGTM on the principle. Just a couple details.
python/pyarrow/tests/test_array.py
Outdated
Member
There was a problem hiding this comment.
Ah, I hadn't noticed that StringArray had a different from_buffers method.
Member
Author
There was a problem hiding this comment.
Frankly I question whether it is useful, I am inclined to remove it
Member
There was a problem hiding this comment.
Remove this, it is probably only used by fletcher and pyarrow.jvm.
pitrou
approved these changes
Jun 13, 2019
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to Antoine's recent work on
Array::Viewthis method can be made more robust and safe by checking for the correct number of buffers.