GH-44297: [Integration][CI] Skip nanoarrow IPC integration tests for compressed/dictionary-encoded files#44298
Merged
kou merged 1 commit intoapache:mainfrom Oct 4, 2024
Conversation
paleolimbot
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
|
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ac2a93d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
There are a few remaining failures when testing nanoarrow against itself: apache/arrow-nanoarrow#643 . Our IPC reader doesn't support dictionaries or compression, so we can't run those tests.
What changes are included in this PR?
Skips were added to the archery code that runs the tests.
Are these changes tested?
Yes (integration tests run on every commit)
Are there any user-facing changes?
No!