Skip to content

Comments

GH-44155: [Archery][Integration] Rename "language" to "implementation"#44156

Merged
kou merged 2 commits intoapache:mainfrom
kou:archery-integration-implementation
Sep 19, 2024
Merged

GH-44155: [Archery][Integration] Rename "language" to "implementation"#44156
kou merged 2 commits intoapache:mainfrom
kou:archery-integration-implementation

Conversation

@kou
Copy link
Member

@kou kou commented Sep 18, 2024 •
edited by github-actions bot
Loading

Rationale for this change

Because there is not a language, nanoarrow, for integration test targets.

What changes are included in this PR?

  • Rename "language" to "implementation" in documents and variable names
  • Rename --target-languages to --target-implementations
  • Rename ARCHERY_INTEGRATION_TARGET_LANGUAGES to ARCHERY_INTEGRATION_TARGET_IMPLEMENTATIONS

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou
apacheGH-44155: [Archery][Integration] Rename "language" to "implemen…
2ef61c3 
…tation"

Because there is not a language, nanoarrow, for integration test
targets.
@github-actions
Copy link

github-actions bot commented Sep 18, 2024

⚠️ GitHub issue #44155 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Sep 18, 2024
This was referenced Sep 18, 2024
Merged
Merged
@kou
Copy link
Member Author

kou commented Sep 18, 2024

Needless patterns such as Rust -> Rust still don't exist:

https://github.com/apache/arrow/actions/runs/10914527860/job/30292784126?pr=44156#step:10:6544

Integration: Test: IPC: C++ -> C++
Integration: Test: IPC: C++ -> Java
Integration: Test: IPC: C++ -> JS
Integration: Test: IPC: C++ -> C#
Integration: Test: IPC: Java -> C++
Integration: Test: IPC: Java -> Java
Integration: Test: IPC: Java -> JS
Integration: Test: IPC: Java -> C#
Integration: Test: IPC: JS -> C++
Integration: Test: IPC: JS -> Java
Integration: Test: IPC: JS -> JS
Integration: Test: IPC: JS -> C#
Integration: Test: IPC: C# -> C++
Integration: Test: IPC: C# -> Java
Integration: Test: IPC: C# -> JS
Integration: Test: IPC: C# -> C#
Integration: Test: IPC: C++ -> Go
Integration: Test: IPC: C++ -> Rust
Integration: Test: IPC: Java -> Go
Integration: Test: IPC: Java -> Rust
Integration: Test: IPC: JS -> Go
Integration: Test: IPC: JS -> Rust
Integration: Test: IPC: C# -> Go
Integration: Test: IPC: C# -> Rust
Integration: Test: IPC: Go -> C++
Integration: Test: IPC: Go -> Java
Integration: Test: IPC: Go -> JS
Integration: Test: IPC: Go -> C#
Integration: Test: IPC: Rust -> C++
Integration: Test: IPC: Rust -> Java
Integration: Test: IPC: Rust -> JS
Integration: Test: IPC: Rust -> C#
Integration: Test: IPC: Gold: C++
Integration: Test: IPC: C++ -> C++

@kou kou mentioned this pull request Sep 18, 2024
Merged
@kou
Copy link
Member Author

kou commented Sep 19, 2024

+1

@kou kou merged commit a6f736c into apache:main Sep 19, 2024
@kou kou removed the awaiting committer review Awaiting committer review label Sep 19, 2024
@kou kou deleted the archery-integration-implementation branch September 19, 2024 02:45
@kou kou mentioned this pull request Sep 19, 2024
Closed
@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Sep 19, 2024

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a6f736c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@jonkeane jonkeane Awaiting requested review from jonkeane jonkeane is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kou