GH-43785: [Python][CI] Correct PARQUET_TEST_DATA path in wheel tests#43786
Merged
jorisvandenbossche merged 2 commits intoapache:mainfrom Aug 22, 2024
Merged
Conversation
jorisvandenbossche
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
Member
Author
|
@github-actions crossbow submit -g wheel |
|
|
jorisvandenbossche
changed the title
|
Revision: 04c4735 Submitted crossbow builds: ursacomputing/crossbow @ actions-0d618e3f18
|
jorisvandenbossche
changed the title
Member
|
Thanks for the good catch! |
Member
Author
|
Going to merge this quickly to get nightly wheels uploaded again |
jorisvandenbossche
removed
the
awaiting committer review
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit fc54ead. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Starting with #41580, the pyarrow tests now also rely on a file in the parquet-testing submodule. And the path to that directory is controlled by
PARQUET_TEST_DATA, which appears to be set wrongly in the wheel test scripts, causing all wheel builds to fail at the moment.