Skip to content

GH-40718: [JS] Fix set visitor in vectors for js dates #40725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
domoritz merged 1 commit into from
Mar 22, 2024
Merged

GH-40718: [JS] Fix set visitor in vectors for js dates #40725

domoritz merged 1 commit into from
Mar 22, 2024

Conversation

@domoritz
Copy link
Member

@domoritz domoritz commented Mar 21, 2024 •
edited
Loading

@domoritz domoritz requested a review from trxcllnt as a code owner March 21, 2024 20:37
@domoritz domoritz mentioned this pull request Mar 21, 2024
Closed
@github-actions
Copy link

github-actions bot commented Mar 21, 2024

⚠️ GitHub issue #40718 has been automatically assigned in GitHub to PR creator.

@Fil Fil mentioned this pull request Mar 21, 2024
Closed
trxcllnt
trxcllnt requested changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domoritz seems like there's more than just the #40718 fixes in here?

@trxcllnt trxcllnt self-requested a review March 21, 2024 22:12
@domoritz
Copy link
Member Author

domoritz commented Mar 21, 2024 •
edited
Loading

I started this off of #40712 since the code used at.

@domoritz
Copy link
Member Author

domoritz commented Mar 22, 2024

I removed the code for the other pull request.

@domoritz domoritz merged commit 2babda0 into apache:main Mar 22, 2024
@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Mar 23, 2024

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2babda0.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

Assignees

No one assigned

Labels

awaiting committer review Awaiting committer review Component: JavaScript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@domoritz @trxcllnt