Repository navigation
GH-40328: [C++][Parquet] Allow use of FileDecryptionProperties after the CryptoFactory is destroyed - #40329
Merged
Conversation
wgtmac
reviewed
Mar 4, 2024
wgtmac
reviewed
Mar 12, 2024
pitrou
reviewed
Mar 15, 2024
pitrou
reviewed
Mar 15, 2024
adamreeve
force-pushed
the
keep_key_retriever_alive
branch
from
March 20, 2024 23:37
115227a to
387e1f2
Compare
Member
|
@github-actions crossbow submit -g cpp |
|
Revision: 387e1f2 Submitted crossbow builds: ursacomputing/crossbow @ actions-2e333fc810
|
Member
|
@github-actions crossbow submit -g cpp |
|
Revision: 7547c79 Submitted crossbow builds: ursacomputing/crossbow @ actions-67652940da
|
Member
|
The duckdb test failures on R builds are unrelated. |
pitrou
approved these changes
Mar 21, 2024
pitrou
left a comment
pitrou
left a comment
Member
There was a problem hiding this comment.
+1 @adamreeve , thanks for this improvement.
mapleFU
approved these changes
Mar 21, 2024
| std::shared_ptr<KmsClientFactory> kms_client_factory, | ||
| EncryptionConfiguration encryption_config) { | ||
| std::shared_ptr<CryptoFactory> crypto_factory = std::make_shared<CryptoFactory>(); | ||
| crypto_factory->RegisterKmsClientFactory(kms_client_factory); |
Member
There was a problem hiding this comment.
Nit: should we use std::move for kms_client_factory?
| std::shared_ptr<KmsClientFactory> kms_client_factory, | ||
| DecryptionConfiguration decryption_config) { | ||
| std::shared_ptr<CryptoFactory> crypto_factory = std::make_shared<CryptoFactory>(); | ||
| crypto_factory->RegisterKmsClientFactory(kms_client_factory); |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 54c4ced. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #40328
What changes are included in this PR?
Changes
FileKeyUnwrapperso it can hold a shared pointer to aKeyToolkitand remain usable after theCryptoFactorythat created it is destroyed. Also changesCryptoFactoryto store a shared pointer to aKeyToolkitinstead of storing aKeyToolkitinline.Are these changes tested?
Yes, I've added a new unit test for this
Are there any user-facing changes?
This changes functionality for users of the C++ API in a non-breaking way, allowing them to use the
FileDecryptionPropertiesreturned from aCryptoFactorywithout having to keep theCryptoFactoryalive.