GH-39778: [C++] Fix tail-byte access cross buffer boundary in key hash avx2#39800
GH-39778: [C++] Fix tail-byte access cross buffer boundary in key hash avx2#39800pitrou merged 7 commits intoapache:mainfrom
Conversation
|
cc @pitrou |
github-actions
bot
added
awaiting committer review
|
@github-actions crossbow submit -g cpp |
|
Revision: 5fea9bb Submitted crossbow builds: ursacomputing/crossbow @ actions-cfeb62c110
|
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 13b2234. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 202 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 13b2234. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 202 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ey hash avx2 (apache#39800) ### Rationale for this change Issue apache#39778 seems caused by a careless (but hard to spot) bug in key hash avx2. ### What changes are included in this PR? Fix the careless bug. ### Are these changes tested? UT included. ### Are there any user-facing changes? No. * Closes: apache#39778 Authored-by: Ruoxi Sun <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
…h avx2 (#39800) ### Rationale for this change Issue #39778 seems caused by a careless (but hard to spot) bug in key hash avx2. ### What changes are included in this PR? Fix the careless bug. ### Are these changes tested? UT included. ### Are there any user-facing changes? No. * Closes: #39778 Authored-by: Ruoxi Sun <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
2 participants
Rationale for this change
Issue #39778 seems caused by a careless (but hard to spot) bug in key hash avx2.
What changes are included in this PR?
Fix the careless bug.
Are these changes tested?
UT included.
Are there any user-facing changes?
No.
arrow::compute::Hashing32::ProcessStripes_avx2#39778