Skip to content

GH-39251: [JS] Use resizable buffer in builder#39252

Merged
domoritz merged 5 commits intoapache:mainfrom
domoritz:dom/resize
Dec 27, 2023
Merged

GH-39251: [JS] Use resizable buffer in builder#39252
domoritz merged 5 commits intoapache:mainfrom
domoritz:dom/resize

Conversation

@domoritz
Copy link
Copy Markdown
Member

@domoritz domoritz commented Dec 16, 2023 •
edited
Loading

This should reduce explicit memory copies in js and make our code simpler. Support is not everywhere: https://caniuse.com/mdn-javascript_builtins_arraybuffer_resizable but I implemented fallbacks.

@domoritz domoritz requested a review from trxcllnt as a code owner December 16, 2023 19:14
@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Dec 16, 2023
@domoritz
Copy link
Copy Markdown
Member Author

domoritz commented Dec 16, 2023

@ursabot please benchmark lang=JavaScript

@ursabot
Copy link
Copy Markdown

ursabot commented Dec 16, 2023

Benchmark runs are scheduled for commit ab87daf. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete.

@conbench-apache-arrow
Copy link
Copy Markdown

conbench-apache-arrow Bot commented Dec 16, 2023

Thanks for your patience. Conbench analyzed the 1 benchmarking run that has been run so far on PR commit ab87daf.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@domoritz domoritz mentioned this pull request Dec 17, 2023
Closed
@domoritz domoritz merged commit ae627c0 into apache:main Dec 27, 2023
@conbench-apache-arrow
Copy link
Copy Markdown

conbench-apache-arrow Bot commented Dec 27, 2023

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit ae627c0.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

This was referenced Jan 14, 2024
Closed
Merged
@domoritz domoritz deleted the dom/resize branch January 15, 2024 11:32
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@domoritz @dgreiss
apacheGH-39251: [JS] Use resizable buffer in builder (apache#39252)
33aaf43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

Assignees

No one assigned

Labels

awaiting committer review Awaiting committer review Component: JavaScript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[JS]: Use resizable array buffers

3 participants

@domoritz @ursabot @trxcllnt