GH-38402: [CI][Integration] Provide wrapper scripts for integration testing#38403
GH-38402: [CI][Integration] Provide wrapper scripts for integration testing#38403kou merged 2 commits intoapache:mainfrom
Conversation
tustvold
left a comment
tustvold
left a comment
There was a problem hiding this comment.
My bash-fu isn't really good enough to review this, but excited to see this 👍
github-actions
bot
added
awaiting changes
| set -ex | ||
|
|
||
| arrow_dir=${1} | ||
| build_dir=${2} |
There was a problem hiding this comment.
It seems that this isn't used. Do we need this?
github-actions
bot
added
awaiting change review
|
@kou Could you review this again? |
|
@tustvold Could you try this in apache/arrow-rs? |
| --with-csharp=$([ "$ARROW_INTEGRATION_CSHARP" == "ON" ] && echo "1" || echo "0") \ | ||
| --with-go=$([ "$ARROW_INTEGRATION_GO" == "ON" ] && echo "1" || echo "0") \ | ||
| --with-java=$([ "$ARROW_INTEGRATION_JAVA" == "ON" ] && echo "1" || echo "0") \ | ||
| --with-js=$([ "$ARROW_INTEGRATION_JS" == "ON" ] && echo "1" || echo "0") \ |
There was a problem hiding this comment.
I think we need a with-rust here in order to use this in arrow-rs
There was a problem hiding this comment.
There's no with-rust currently. The ARCHERY_INTEGRATION_WITH_RUST environment variable is used.
There was a problem hiding this comment.
We're currently using it - https://github.com/apache/arrow-rs/blob/master/.github/workflows/integration.yml#L121
I'll give the env variable a go as well
There was a problem hiding this comment.
Ahah... I don't know why we have both then.
github-actions
bot
added
awaiting changes
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 99f893f. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…tion testing (apache#38403) ### Rationale for this change It is currently cumbersome to run integration tests from an other repository, as each tested implementation must be built explicitly. See explanatory comment at apache/arrow-rs#4957 (comment) ### What changes are included in this PR? Provide a wrapper script to automate building the implementations being tested. Allow usage of environment variables such as `ARROW_INTEGRATION_CPP`, etc. to selectively disable implementations. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. * Closes: apache#38402 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…tion testing (apache#38403) ### Rationale for this change It is currently cumbersome to run integration tests from an other repository, as each tested implementation must be built explicitly. See explanatory comment at apache/arrow-rs#4957 (comment) ### What changes are included in this PR? Provide a wrapper script to automate building the implementations being tested. Allow usage of environment variables such as `ARROW_INTEGRATION_CPP`, etc. to selectively disable implementations. ### Are these changes tested? Yes, by construction. ### Are there any user-facing changes? No. * Closes: apache#38402 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
3 participants
Rationale for this change
It is currently cumbersome to run integration tests from an other repository, as each tested implementation must be built explicitly.
See explanatory comment at apache/arrow-rs#4957 (comment)
What changes are included in this PR?
Provide a wrapper script to automate building the implementations being tested.
Allow usage of environment variables such as
ARROW_INTEGRATION_CPP, etc. to selectively disable implementations.Are these changes tested?
Yes, by construction.
Are there any user-facing changes?
No.