Skip to content

GH-38059: [Python][CI] Upgrade CUDA to 11.2.2#38081

Merged
kou merged 3 commits intoapache:mainfrom
danepitkin:danepitkin/upgrade-cuda
Oct 10, 2023
Merged

GH-38059: [Python][CI] Upgrade CUDA to 11.2.2#38081
kou merged 3 commits intoapache:mainfrom
danepitkin:danepitkin/upgrade-cuda

Conversation

@danepitkin
Copy link
Member

@danepitkin danepitkin commented Oct 6, 2023 •
edited by github-actions bot
Loading

Rationale for this change

Numba v0.58 requires cuda-toolkit >= v11.2

What changes are included in this PR?

  • Upgrade CUDA from 11.0.3 -> 11.2.2

Are these changes tested?

Will test in CI

Are there any user-facing changes?

Yes

@danepitkin
Copy link
Member Author

danepitkin commented Oct 6, 2023

@github-actions crossbow submit cuda

@danepitkin danepitkin marked this pull request as draft October 6, 2023 16:08
@github-actions github-actions bot added the awaiting review Awaiting review label Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Revision: 06fc8f5

Submitted crossbow builds: ursacomputing/crossbow @ actions-8955e0b5d3

Task Status
conda-linux-aarch64-cuda-py3 Azure
conda-linux-ppc64le-cuda-py3 Azure
conda-linux-x64-cuda-py3 Azure
conda-win-x64-cuda-py3 Azure
test-cuda-cpp Github Actions
test-cuda-python Github Actions

@danepitkin danepitkin changed the title Upgrade CUDA to 11.2.2 GH-38059: [Python][CI] Upgrade CUDA to 11.2.2 Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

⚠️ GitHub issue #38059 has been automatically assigned in GitHub to PR creator.

@danepitkin danepitkin requested a review from zeroshade October 6, 2023 16:31
@danepitkin
Copy link
Member Author

danepitkin commented Oct 6, 2023

@github-actions crossbow submit cuda

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Revision: 834b29e

Submitted crossbow builds: ursacomputing/crossbow @ actions-db8dfc513e

Task Status
conda-linux-aarch64-cuda-py3 Azure
conda-linux-ppc64le-cuda-py3 Azure
conda-linux-x64-cuda-py3 Azure
conda-win-x64-cuda-py3 Azure
test-cuda-cpp Github Actions
test-cuda-python Github Actions

@danepitkin danepitkin marked this pull request as ready for review October 6, 2023 19:08
@kou
Copy link
Member

kou commented Oct 6, 2023

@github-actions crossbow submit debian-* ubuntu-*

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Revision: 834b29e

Submitted crossbow builds: ursacomputing/crossbow @ actions-0381279f14

Task Status
debian-bookworm-amd64 Github Actions
debian-bookworm-arm64 Github Actions
debian-bullseye-amd64 Github Actions
debian-bullseye-arm64 Github Actions
debian-trixie-amd64 Github Actions
debian-trixie-arm64 Github Actions
ubuntu-focal-amd64 Github Actions
ubuntu-focal-arm64 Github Actions
ubuntu-jammy-amd64 Github Actions
ubuntu-jammy-arm64 Github Actions
ubuntu-lunar-amd64 Github Actions
ubuntu-lunar-arm64 Github Actions

Revert "Use cuda enum"
14b7cfc 
This reverts commit 834b29e.
@danepitkin
Copy link
Member Author

danepitkin commented Oct 6, 2023

Good catch, looks like one of the CI jobs still doesn't like the enum added (I thought 11.2.2 had added it). Reverted the change.

This is the CI error:

/build/apache-arrow-14.0.0.dev263/cpp/src/arrow/gpu/cuda_context.cc:326:57: error: ‘CU_EVENT_WAIT_DEFAULT’ was not declared in this scope; did you mean ‘CU_EVENT_DEFAULT’?
  326 |                    cuStreamWaitEvent(value(), cu_event, CU_EVENT_WAIT_DEFAULT));
      |                                                         ^~~~~~~~~~~~~~~~~~~~~
/build/apache-arrow-14.0.0.dev263/cpp/src/arrow/gpu/cuda_internal.h:41:23: note: in definition of macro ‘CU_RETURN_NOT_OK’
   41 |     CUresult __res = (STMT);                                            \
      |                       ^~~~

@danepitkin
Copy link
Member Author

danepitkin commented Oct 6, 2023

Well.. it probably is added, but needs to be included somewhere. Either way, I don't have much time to dig into before the Arrow v14 release.

@danepitkin
Copy link
Member Author

danepitkin commented Oct 6, 2023

@github-actions crossbow submit ubuntu-focal-amd64

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Revision: 14b7cfc

Submitted crossbow builds: ursacomputing/crossbow @ actions-b62f8c70c6

Task Status
ubuntu-focal-amd64 Github Actions

kou
kou approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
Copy link
Member

kou commented Oct 10, 2023

The no space left error is unrelated.

@kou kou merged commit 9f18a25 into apache:main Oct 10, 2023
@kou kou removed the awaiting review Awaiting review label Oct 10, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Oct 10, 2023
@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Oct 11, 2023

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 9f18a25.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
@danepitkin @loicalleyne
apacheGH-38059: [Python][CI] Upgrade CUDA to 11.2.2 (apache#38081)
a80761e 
### Rationale for this change

Numba v0.58 requires cuda-toolkit >= v11.2

### What changes are included in this PR?

* Upgrade CUDA from 11.0.3 -> 11.2.2

### Are these changes tested?

Will test in CI

### Are there any user-facing changes?

Yes
* Closes: apache#38059

Authored-by: Dane Pitkin <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@danepitkin @dgreiss
apacheGH-38059: [Python][CI] Upgrade CUDA to 11.2.2 (apache#38081)
dd5b71e 
### Rationale for this change

Numba v0.58 requires cuda-toolkit >= v11.2

### What changes are included in this PR?

* Upgrade CUDA from 11.0.3 -> 11.2.2

### Are these changes tested?

Will test in CI

### Are there any user-facing changes?

Yes
* Closes: apache#38059

Authored-by: Dane Pitkin <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

@zeroshade zeroshade Awaiting requested review from zeroshade

Assignees

No one assigned

Labels

awaiting merge Awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Python][CI] test-cuda-python fails, requires cuda-toolkit v11.2

2 participants

@danepitkin @kou