Skip to content

GH-37392: [JS] Remove lerna#37393

Merged
kou merged 2 commits into
apache:mainfrom
domoritz:dom/lerna
Aug 25, 2023
Merged

GH-37392: [JS] Remove lerna#37393
kou merged 2 commits into
apache:mainfrom
domoritz:dom/lerna

Conversation

@domoritz

@domoritz domoritz commented Aug 25, 2023

Copy link
Copy Markdown
Member

We only use learna for making releases and can easily replace it with a bash script.

Comment thread js/DEVELOP.md
To run tests on the bundles, you need to build them first.
To run tests directly on the sources without bundling, use the `src` target (e.g. `yarn test -t src`).

* `yarn deploy`

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already not working so I removed it.

@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Aug 25, 2023
@github-actions github-actions Bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting committer review Awaiting committer review awaiting changes Awaiting changes labels Aug 25, 2023

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit c9bfca5 into apache:main Aug 25, 2023
@kou kou removed the awaiting change review Awaiting change review label Aug 25, 2023
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Aug 25, 2023
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit c9bfca5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
We only use learna for making releases and can easily replace it with a bash script. 
* Closes: apache#37392

Authored-by: Dominik Moritz <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
kou added a commit to apache/arrow-js that referenced this pull request Jun 12, 2025
## What's Changed

Removed `lerna` from `package`json` because we removed `lerna` in
apache/arrow#37393.

Closes #143.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JS] Remove Lerna

3 participants