Skip to content

GH-37303: [Python] Update test_option_class_equality due to CumulativeSumOptions refactor#37305

Merged
jorisvandenbossche merged 1 commit intoapache:mainfrom
AlenkaF:gh-37303-CumulativeSumOptions-warning
Aug 23, 2023
Merged

GH-37303: [Python] Update test_option_class_equality due to CumulativeSumOptions refactor#37305
jorisvandenbossche merged 1 commit intoapache:mainfrom
AlenkaF:gh-37303-CumulativeSumOptions-warning

Conversation

@AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Aug 22, 2023 •
edited by github-actions bot
Loading

Rationale for this change

Merging of #36977 caused a CI failure due to a test giving a warning.

What changes are included in this PR?

Add a filterwarnings mark to the failing tests. This also tests the deprecation message.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Aug 22, 2023

@AlenkaF you might have to trigger some of the python crossbow builds to properly test this

cc @danepitkin given the last commit on main is green, does this mean we only enable the "-W error" for nightly builds? We should probably configure that for one of the main CI's python builds as well for better visibility?)

@AlenkaF
Copy link
Member Author

AlenkaF commented Aug 22, 2023

@github-actions crossbow submit test-conda-python*

@github-actions
Copy link

github-actions bot commented Aug 22, 2023

Revision: 3cf5c09

Submitted crossbow builds: ursacomputing/crossbow @ actions-27a0f5201c

Task Status
test-conda-python-3.10 Github Actions
test-conda-python-3.10-hdfs-2.9.2 Github Actions
test-conda-python-3.10-hdfs-3.2.1 Github Actions
test-conda-python-3.10-pandas-latest Github Actions
test-conda-python-3.10-pandas-nightly Github Actions
test-conda-python-3.10-spark-v3.4.1 Github Actions
test-conda-python-3.10-substrait Github Actions
test-conda-python-3.11 Github Actions
test-conda-python-3.11-dask-latest Github Actions
test-conda-python-3.11-dask-upstream_devel Github Actions
test-conda-python-3.11-hypothesis Github Actions
test-conda-python-3.11-pandas-upstream_devel Github Actions
test-conda-python-3.11-spark-master Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-pandas-1.0 Github Actions
test-conda-python-3.8-spark-v3.4.1 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-pandas-latest Github Actions

@danepitkin
Copy link
Member

danepitkin commented Aug 22, 2023

@AlenkaF you might have to trigger some of the python crossbow builds to properly test this

cc @danepitkin given the last commit on main is green, does this mean we only enable the "-W error" for nightly builds? We should probably configure that for one of the main CI's python builds as well for better visibility?)

Whoops, yes this is correct. I filed an issue to fix it: #37310

@jorisvandenbossche jorisvandenbossche merged commit ac5468c into apache:main Aug 23, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Aug 23, 2023
@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Aug 24, 2023

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit ac5468c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

@AlenkaF AlenkaF deleted the gh-37303-CumulativeSumOptions-warning branch August 24, 2023 05:40
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
@AlenkaF @loicalleyne
apacheGH-37303: [Python] Update test_option_class_equality due to Cum…
fdbfb1c 
…ulativeSumOptions refactor (apache#37305)

### Rationale for this change

Merging of apache#36977 caused a CI failure due to a test giving a warning.

### What changes are included in this PR?

Add a `filterwarnings` mark to the failing tests. This also tests the deprecation message.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#37303

Authored-by: AlenkaF <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees

No one assigned

Labels

awaiting merge Awaiting merge Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Python] Update test_option_class_equality due to CumulativeSumOptions refactor

3 participants

@AlenkaF @jorisvandenbossche @danepitkin