Skip to content

ARROW-4556: [Rust] Preserve JSON field order when inferring schema#3702

Closed
nevi-me wants to merge 2 commits intoapache:masterfrom
nevi-me:arrow-4556
Closed

ARROW-4556: [Rust] Preserve JSON field order when inferring schema#3702
nevi-me wants to merge 2 commits intoapache:masterfrom
nevi-me:arrow-4556

Conversation

@nevi-me
Copy link
Contributor

@nevi-me nevi-me commented Feb 19, 2019

Uses the preserve-order feature in serde_json, which is required to guarantee that we iterate through JSON records' keys in their provided order.
Adds crate indexmap, which serde_json already uses.

@nevi-me nevi-me changed the title Arrow 4556 Arrow-4556: [Rust] Preserve JSON field order when inferring schema Feb 19, 2019
@nevi-me nevi-me changed the title Arrow-4556: [Rust] Preserve JSON field order when inferring schema ARROW-4556: [Rust] Preserve JSON field order when inferring schema Feb 19, 2019
@nevi-me nevi-me marked this pull request as ready for review February 19, 2019 12:56
Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kszucs
Copy link
Member

kszucs commented Feb 19, 2019

Travis failures are unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants