GH-36787: [R] lintr update leads to failing tests on main#36788
Merged
thisisnic merged 1 commit intoapache:mainfrom Jul 20, 2023
Merged
GH-36787: [R] lintr update leads to failing tests on main#36788thisisnic merged 1 commit intoapache:mainfrom
thisisnic merged 1 commit intoapache:mainfrom
Conversation
paleolimbot
approved these changes
Jul 20, 2023
Member
paleolimbot
left a comment
paleolimbot
left a comment
There was a problem hiding this comment.
Thanks! Just curious...is it worth fixing the indentation problems or are they spurious?
github-actions
bot
added
awaiting merge
Member
Author
Good question! I had a look at some of them, and they seem to be stylistic choices which don't make the code look better rather than fixing true problems. More importantly, using |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit fca6a66. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…he#36788) ### What changes are included in this PR? Turning off the newly introduced indentation linter as it causes test failures, and isn't in sync with styler which we use to style our code. ### Are these changes tested? No, is linter config. ### Are there any user-facing changes? No * Closes: apache#36787 Authored-by: Nic Crane <[email protected]> Signed-off-by: Nic Crane <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
Turning off the newly introduced indentation linter as it causes test failures, and isn't in sync with styler which we use to style our code.
Are these changes tested?
No, is linter config.
Are there any user-facing changes?
No