Skip to content

PARQUET-1532: [C++] Fix build error with MinGW#3676

Closed
kou wants to merge 1 commit intoapache:masterfrom
kou:cpp-parquet-fix-build-error-with-mingw
Closed

PARQUET-1532: [C++] Fix build error with MinGW#3676
kou wants to merge 1 commit intoapache:masterfrom
kou:cpp-parquet-fix-build-error-with-mingw

Conversation

@kou
Copy link
Member

@kou kou commented Feb 17, 2019

Error message:

In file included from C:/msys64/mingw64/include/thrift/TApplicationException.h:23,
                 from C:/Users/kou/work/arrow/arrow.kou/cpp/src/parquet/thrift.h:35,
                 from C:/Users/kou/work/arrow/arrow.kou/cpp/src/parquet/column_reader.cc:36:
C:/msys64/mingw64/include/thrift/Thrift.h:32:10: fatal error: netinet/in.h: No such file or directory
 #include <netinet/in.h>
          ^~~~~~~~~~~~~~

@kou
[C++] Fix build error with MinGW
248063c 
Error message:

    In file included from C:/msys64/mingw64/include/thrift/TApplicationException.h:23,
                     from C:/Users/kou/work/arrow/arrow.kou/cpp/src/parquet/thrift.h:35,
                     from C:/Users/kou/work/arrow/arrow.kou/cpp/src/parquet/column_reader.cc:36:
    C:/msys64/mingw64/include/thrift/Thrift.h:32:10: fatal error: netinet/in.h: No such file or directory
     #include <netinet/in.h>
              ^~~~~~~~~~~~~~
@kszucs kszucs closed this in 3f3da9d Feb 17, 2019
@kszucs
Copy link
Member

kszucs commented Feb 17, 2019

@kou I'm not allowed to edit PARQUET project on jira, so I cannot change the fix version. Could You please grant me permissions?

@kou kou deleted the cpp-parquet-fix-build-error-with-mingw branch February 17, 2019 20:54
@kou
Copy link
Member Author

kou commented Feb 17, 2019

Ah, I don't have permission for PARQUET project.
(I could close this issue because I'm the reporter.)

@wesm @xhochy What should we do for PARQUET issues? @kszucs and I can merge changes to this repository but can't change PARQUET issues. Should we wait @wesm, @xhochy or someone for PARQUET issues?

@wesm
Copy link
Member

wesm commented Feb 17, 2019

@kou I'll make you a contributor on PARQUET

@kou
Copy link
Member Author

kou commented Feb 17, 2019

Thanks!

@wesm
Copy link
Member

wesm commented Feb 17, 2019

I added @kszucs as a Contributor so he should be able to edit fix versions now

@asfimport asfimport mentioned this pull request Jun 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kszucs kszucs kszucs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kou @kszucs @wesm