ARROW-4537: [CI] Suppress shell warning on travis-ci#3623
Closed
mrkn wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-4537: [CI] Suppress shell warning on travis-ci#3623mrkn wants to merge 1 commit intoapache:masterfrom
mrkn wants to merge 1 commit intoapache:masterfrom
Conversation
mrkn
changed the title
mrkn
force-pushed
the
suppress_shell_warning_on_ci
branch
from
37ae158 to
234fdfb
Compare
xhochy
requested changes
Feb 12, 2019
Member
xhochy
left a comment
xhochy
left a comment
There was a problem hiding this comment.
+1, thanks!
Can you address the one line where you did the reverse?
ci/travis_before_script_cpp.sh
Outdated
Member
There was a problem hiding this comment.
Shouldn't the quotes stay here as-is?
Member
Author
There was a problem hiding this comment.
It's my mistake. I reverted this change. Thanks for catching this.
Enclose optional shell variable names by double quotations to suppress shell warnings that is like below: ``` +'[' == 1 ']' /home/travis/build/apache/arrow/ci/travis_before_script_cpp.sh: line 81: [: ==: unary operator expected ```
mrkn
force-pushed
the
suppress_shell_warning_on_ci
branch
from
234fdfb to
4db2e53
Compare
xhochy
approved these changes
Feb 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enclose optional shell variable names by double quotations to suppress shell warnings that is like below: