Skip to content

GH-35669: [C++] Update to double-conversion 3.3.0, activate new flags, remove patches #36002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 4 commits into from
Jun 9, 2023
Merged

GH-35669: [C++] Update to double-conversion 3.3.0, activate new flags, remove patches #36002

kou merged 4 commits into from
Jun 9, 2023

Conversation

@ianmcook
Copy link
Member

@ianmcook ianmcook commented Jun 8, 2023 •
edited
Loading

double-conversion v3.3.0 adds a new feature that allows us to remove the special code that was added to our vendored copy of double-conversion in #9816.

This PR:

  • Updates vendored double-conversion to v3.3.0
  • Activates the new flags EMIT_TRAILING_DECIMAL_POINT_IN_EXPONENTIAL and EMIT_TRAILING_ZERO_AFTER_POINT_IN_EXPONENTIAL
  • Removes the patches in cpp/src/arrow/vendored/double-conversion/patches

kou
kou approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks!!!

@kou kou merged commit 0bbfe98 into apache:main Jun 9, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 9, 2023
@ursabot
Copy link

ursabot commented Jun 10, 2023

Benchmark runs are scheduled for baseline = 6808bfe and contender = 0bbfe98. 0bbfe98 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.68% ⬆️0.03%] test-mac-arm
[Finished ⬇️2.94% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.33% ⬆️0.33%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 0bbfe983 ec2-t3-xlarge-us-east-2
[Failed] 0bbfe983 test-mac-arm
[Finished] 0bbfe983 ursa-i9-9960x
[Finished] 0bbfe983 ursa-thinkcentre-m75q
[Finished] 6808bfe3 ec2-t3-xlarge-us-east-2
[Finished] 6808bfe3 test-mac-arm
[Finished] 6808bfe3 ursa-i9-9960x
[Finished] 6808bfe3 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

Assignees

No one assigned

Labels

awaiting merge Awaiting merge Component: C++ Component: Documentation Component: Gandiva

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++] Update to double-conversion 3.3.0, activate new flags, remove patches

3 participants

@ianmcook @ursabot @kou