ARROW-4423: [C++] Upgrade vendored gmock/gtest to 1.8.1#3589
Closed
emkornfield wants to merge 4 commits intoapache:masterfrom
Closed
ARROW-4423: [C++] Upgrade vendored gmock/gtest to 1.8.1#3589emkornfield wants to merge 4 commits intoapache:masterfrom
emkornfield wants to merge 4 commits intoapache:masterfrom
Conversation
Member
|
Rebased. |
Member
|
I can try to look at the Windows build later if you can't figure it out. BTW you can get free Windows 10 ISO from Microsoft so setting up a windows dev environment isn't as hard as you might think |
Contributor
Author
|
Thanks. I think I should be able to handle everything. My first step is
to figure out Trusty errors (I also have a Windows VM) setup so I can look
at that as well it might just take a little while.
…On Saturday, February 9, 2019, Wes McKinney ***@***.***> wrote:
I can try to look at the Windows build later if you can't figure it out.
BTW you can get free Windows 10 ISO from Microsoft so setting up a windows
dev environment isn't as hard as you might think
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3589 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARCsDuTgy7N3fiVIbWUZ_yD0AgTGqMFmks5vLzq4gaJpZM4at3v8>
.
|
emkornfield
force-pushed
the
upgrade_gmock
branch
from
430d48b to
200dec7
Compare
emkornfield
changed the title
emkornfield
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3589 +/- ##
==========================================
+ Coverage 87.76% 88.62% +0.85%
==========================================
Files 673 544 -129
Lines 82763 73796 -8967
Branches 1069 0 -1069
==========================================
- Hits 72640 65400 -7240
+ Misses 10012 8396 -1616
+ Partials 111 0 -111
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change seems to indicate an alternative would be to force the build to be Release type (and avoid the naming magic). It doesn't appear that the conda feedstock (https://github.com/conda-forge/gtest-feedstock/blob/master/recipe/build.sh) builds debug for linux at all. it does for windows though:
(https://github.com/conda-forge/gtest-feedstock/blob/master/recipe/bld.bat) I'm not sure if we care a lot about this?