ARROW-4474: Use signed integers in FlightInfo payload size fields#3555
Conversation
wesm
reviewed
Feb 9, 2019
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
I'm +1 on the change. The C++ bindings will have to be updated because they use uint64_t. @jacques-n will this pose any issue for Java?
Contributor
|
I'm +1 as well. Java actually supports signed better. |
Author
|
Alright, I've changed what I believe are all the relevant occurrences of |
Member
|
Rebased. It seems Java doesn't need any changes (the relevant fields are already |
Member
|
Hmm I'm not sure what happened to the CI here. I'm sure the Travis build was green... Will re-trigger. |
Member
|
The manylinux job now routinely times out after 50 minutes... @kszucs |
Member
|
I suggest to test only python 2.7 and 3.6, I'll set that in #3484 |
Member
|
+1 merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.