GH-35190: [Go] Correctly handle null values in CSV reader #35191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zeroshade
reviewed
Apr 17, 2023
Comment on lines
768
to
773
| func (r *Reader) parseBinaryType(field array.Builder, str string) { | ||
| // specialize the implementation when we know we cannot have nulls | ||
| if str != "" && r.isNull(str) { | ||
| if r.isNull(str) { | ||
| field.AppendNull() | ||
| return | ||
| } |
Member
There was a problem hiding this comment.
Do we currently have a test that verifies you can still get an empty string if it is not in the list of Null values? / stringsCanBeNull == false ?
Contributor
Author
There was a problem hiding this comment.
I think not, but happy to add one here
Contributor
Author
There was a problem hiding this comment.
Added two new test cases for this
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
kodiakhq bot
pushed a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Apr 18, 2023
This updates the Arrow dependency to the latest `cqmain` branch commit, which includes apache/arrow#35191 and apache/arrow#35189
zeroshade
approved these changes
Apr 18, 2023
github-actions
bot
added
awaiting merge
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this pull request
May 11, 2023
…he#35191) The way the CSV reader handles null values currently makes it impossible for empty strings to be interpreted as null, even when this is explicitly enabled through the `csv.WithNullReader(stringsCanBeNull: true, "", "NULL", "null")` option. This change fixes this. * Closes: apache#35190 Authored-by: Herman Schaaf <[email protected]> Signed-off-by: Matt Topol <[email protected]>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
May 15, 2023
…he#35191) The way the CSV reader handles null values currently makes it impossible for empty strings to be interpreted as null, even when this is explicitly enabled through the `csv.WithNullReader(stringsCanBeNull: true, "", "NULL", "null")` option. This change fixes this. * Closes: apache#35190 Authored-by: Herman Schaaf <[email protected]> Signed-off-by: Matt Topol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the CSV reader handles null values currently makes it impossible for empty strings to be interpreted as null, even when this is explicitly enabled through the
csv.WithNullReader(stringsCanBeNull: true, "", "NULL", "null")option. This change fixes this.