Skip to content

GH-35038: [R] argument order in arrow_table affects object return type #35039

Merged
thisisnic merged 6 commits intoapache:mainfrom
thisisnic:GH-35038_arg_order
Apr 11, 2023
Merged

GH-35038: [R] argument order in arrow_table affects object return type #35039
thisisnic merged 6 commits intoapache:mainfrom
thisisnic:GH-35038_arg_order

Conversation

@thisisnic
Copy link
Copy Markdown
Member

@thisisnic thisisnic commented Apr 11, 2023 •
edited by github-actions bot
Loading

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 11, 2023

@thisisnic thisisnic marked this pull request as ready for review April 11, 2023 13:43
@thisisnic thisisnic requested a review from paleolimbot as a code owner April 11, 2023 13:43
nealrichardson
nealrichardson reviewed Apr 11, 2023
View reviewed changes
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Apr 11, 2023
nealrichardson
nealrichardson approved these changes Apr 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisisnic thisisnic merged commit 6b4e0f6 into apache:main Apr 11, 2023
@ursabot
Copy link
Copy Markdown

ursabot commented Apr 12, 2023

Benchmark runs are scheduled for baseline = aff876a and contender = 6b4e0f6. 6b4e0f6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.37% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 6b4e0f6d ec2-t3-xlarge-us-east-2
[Failed] 6b4e0f6d test-mac-arm
[Finished] 6b4e0f6d ursa-i9-9960x
[Finished] 6b4e0f6d ursa-thinkcentre-m75q
[Finished] aff876a5 ec2-t3-xlarge-us-east-2
[Failed] aff876a5 test-mac-arm
[Finished] aff876a5 ursa-i9-9960x
[Finished] aff876a5 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@paleolimbot paleolimbot mentioned this pull request Apr 19, 2023
Open
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@thisisnic @nealrichardson @liujiacheng777
apacheGH-35038: [R] argument order in arrow_table affects object retu…
8db5c04 
…rn type (apache#35039)

* Closes: apache#35038

Lead-authored-by: Nic Crane <[email protected]>
Co-authored-by: Neal Richardson <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@thisisnic @nealrichardson @ArgusLi
apacheGH-35038: [R] argument order in arrow_table affects object retu…
ab00eed 
…rn type (apache#35039)

* Closes: apache#35038

Lead-authored-by: Nic Crane <[email protected]>
Co-authored-by: Neal Richardson <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nealrichardson nealrichardson nealrichardson approved these changes

@paleolimbot paleolimbot Awaiting requested review from paleolimbot

Assignees

No one assigned

Labels

awaiting changes Awaiting changes Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[R] argument order in arrow_table affects object return type

3 participants

@thisisnic @ursabot @nealrichardson