Skip to content

MINOR: [R] Unskip acero tests#34943

Merged
nealrichardson merged 1 commit intoapache:mainfrom
nealrichardson:unskip-acero-tests
Apr 7, 2023
Merged

MINOR: [R] Unskip acero tests#34943
nealrichardson merged 1 commit intoapache:mainfrom
nealrichardson:unskip-acero-tests

Conversation

@nealrichardson
Copy link
Member

@nealrichardson nealrichardson commented Apr 6, 2023

#34844 inadvertently resulted in skip_if_not_available("acero") to always skip.

@nealrichardson
Copy link
Member Author

nealrichardson commented Apr 7, 2023

Latest run on main: https://github.com/apache/arrow/actions/runs/4634176275/jobs/8200123447#step:7:5348

...
  'test-dplyr-arrange.R:20:1' [skip]
  'test-dplyr-collapse.R:23:1' [skip]
  'test-dplyr-count.R:20:1' [skip]
  'test-dplyr-distinct.R:20:1' [skip]
  'test-dplyr-filter.R:21:1' [skip]
  'test-dplyr-funcs-conditional.R:21:1' [skip]
  'test-dplyr-funcs-datetime.R:24:1' [skip]
  'test-dplyr-funcs-math.R:20:1' [skip]
  'test-dplyr-funcs-string.R:19:1' [skip]
  'test-dplyr-funcs-type.R:22:1' [skip]
...

Here: https://github.com/apache/arrow/actions/runs/4632377834/jobs/8196366469?pr=34943#step:7:5349

...
  'test-dplyr-arrange.R:26:3' [success]
  'test-dplyr-arrange.R:26:3' [success]
  'test-dplyr-arrange.R:32:3' [success]
  'test-dplyr-arrange.R:32:3' [success]
  'test-dplyr-arrange.R:38:3' [success]
  'test-dplyr-arrange.R:38:3' [success]
  'test-dplyr-arrange.R:44:3' [success]
  'test-dplyr-arrange.R:44:3' [success]
  'test-dplyr-arrange.R:50:3' [success]
  'test-dplyr-arrange.R:50:3' [success]
...

@nealrichardson nealrichardson merged commit 14e9e3c into apache:main Apr 7, 2023
@nealrichardson nealrichardson deleted the unskip-acero-tests branch April 7, 2023 16:06
@ursabot
Copy link

ursabot commented Apr 8, 2023

Benchmark runs are scheduled for baseline = 7526df9 and contender = 14e9e3c. 14e9e3c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️2.73% ⬆️0.8%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.49% ⬆️0.18%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 14e9e3cb ec2-t3-xlarge-us-east-2
[Finished] 14e9e3cb test-mac-arm
[Finished] 14e9e3cb ursa-i9-9960x
[Finished] 14e9e3cb ursa-thinkcentre-m75q
[Finished] 7526df9a ec2-t3-xlarge-us-east-2
[Finished] 7526df9a test-mac-arm
[Finished] 7526df9a ursa-i9-9960x
[Finished] 7526df9a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@thisisnic thisisnic mentioned this pull request Apr 11, 2023
Merged
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@nealrichardson @liujiacheng777
MINOR: [R] Unskip acero tests (apache#34943)
85ed44e 
apache#34844 inadvertently resulted in `skip_if_not_available("acero")` to
always skip.
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@nealrichardson @ArgusLi
MINOR: [R] Unskip acero tests (apache#34943)
8e816b2 
apache#34844 inadvertently resulted in `skip_if_not_available("acero")` to
always skip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paleolimbot paleolimbot Awaiting requested review from paleolimbot

@thisisnic thisisnic Awaiting requested review from thisisnic thisisnic is a code owner

Assignees

No one assigned

Labels

awaiting review Awaiting review Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nealrichardson @ursabot