Repository navigation
GH-32950: [Go] REE Benchmarks - #34666
Conversation
|
CC @felipecrv |
|
|
|
| b.SetBytes(byts) | ||
| b.ResetTimer() | ||
| for n := 0; n < b.N; n++ { | ||
| res, err = compute.RunEndEncode(ctx, opts, input) |
There was a problem hiding this comment.
This will vary very widely depending on the size of the runs. Does the REE random generator pay attention to this? Meaning: does it generate a normal distribution of run-lengths?
There was a problem hiding this comment.
so right now it's using a specific seed to ensure consistency, but that's a good point that this benchmark is essentially still just benchmarking a random normal distribution of values with no guarantees to any particular distribution of runs and run-lengths. It might make more sense to restrict the min/max values to better guarantee some runs.
|
Benchmark runs are scheduled for baseline = fd5d710 and contender = a1153a8. a1153a8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
### Rationale for this change Adding benchmarks for `run_end_encode` and `run_end_decode` to track and hopefully improve the performance of these kernels. * Closes: apache#32950 Authored-by: Matt Topol <[email protected]> Signed-off-by: Matt Topol <[email protected]>
Rationale for this change
Adding benchmarks for
run_end_encodeandrun_end_decodeto track and hopefully improve the performance of these kernels.