Skip to content

GH-32338: [C++] Add IPC support for Run-End Encoded Arrays - #34550

Merged
zeroshade merged 4 commits into
apache:mainfrom
felipecrv:rle_ipc
Mar 15, 2023
Merged

zeroshade merged 4 commits into
apache:mainfrom
felipecrv:rle_ipc

Conversation

@felipecrv

@felipecrv felipecrv commented Mar 13, 2023 •

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@felipecrv felipecrv changed the title GH-32338: [C++] Add IPC support for Run-End Encoded Arrays GH-2338: [C++] Add IPC support for Run-End Encoded Arrays Mar 13, 2023
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #2338 has been automatically assigned in GitHub to PR creator.

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #2338 has no components, please add labels for components.

Lead-authored-by: Felipe Oliveira Carvalho <[email protected]>
Co-authored-by: Tobias Zagorni <[email protected]>
@felipecrv felipecrv changed the title GH-2338: [C++] Add IPC support for Run-End Encoded Arrays GH-32338: [C++] Add IPC support for Run-End Encoded Arrays Mar 14, 2023
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #32338 has been automatically assigned in GitHub to PR creator.

1 similar comment
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #32338 has been automatically assigned in GitHub to PR creator.

@felipecrv

Copy link
Copy Markdown
Contributor Author

@zeroshade

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #32338 has been automatically assigned in GitHub to PR creator.

1 similar comment
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #32338 has been automatically assigned in GitHub to PR creator.

@felipecrv
felipecrv marked this pull request as ready for review March 14, 2023 14:20

@zeroshade zeroshade left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM just a few questions

Comment thread cpp/src/arrow/array/array_run_end.cc Resolved
Comment thread cpp/src/arrow/array/array_run_end.cc Resolved
Comment thread cpp/src/arrow/array/array_run_end.h Resolved
@zeroshade
zeroshade merged commit 8ea3769 into apache:main Mar 15, 2023
@felipecrv
felipecrv deleted the rle_ipc branch March 15, 2023 15:08
@ursabot

ursabot commented Mar 15, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 8732b27 and contender = 8ea3769. 8ea3769 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.61% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.26%] ursa-i9-9960x
[Finished ⬇️0.19% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 8ea37690 ec2-t3-xlarge-us-east-2
[Failed] 8ea37690 test-mac-arm
[Finished] 8ea37690 ursa-i9-9960x
[Finished] 8ea37690 ursa-thinkcentre-m75q
[Finished] 8732b278 ec2-t3-xlarge-us-east-2
[Finished] 8732b278 test-mac-arm
[Finished] 8732b278 ursa-i9-9960x
[Finished] 8732b278 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++][Archery] JSON integration testing with RLE [Format][C++] Support RLE in IPC format

4 participants