Skip to content

GH-34367: [Java] Fix build error from sequential merges#34368

Merged
lidavidm merged 1 commit intoapache:mainfrom
lidavidm:gh-34367
Feb 27, 2023
Merged

GH-34367: [Java] Fix build error from sequential merges#34368
lidavidm merged 1 commit intoapache:mainfrom
lidavidm:gh-34367

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Feb 27, 2023 •
edited by github-actions bot
Loading

Rationale for this change

I broke main by merging two PRs in quick succession that unfortunately didn't work together.

What changes are included in this PR?

Fix the build error.

Are these changes tested?

N/A

Are there any user-facing changes?

No, test code only

@github-actions
Copy link

github-actions bot commented Feb 27, 2023

@github-actions
Copy link

github-actions bot commented Feb 27, 2023

⚠️ GitHub issue #34367 has been automatically assigned in GitHub to PR creator.

@lidavidm lidavidm mentioned this pull request Feb 27, 2023
Closed
@lidavidm
Copy link
Member Author

lidavidm commented Feb 27, 2023

@github-actions crossbow submit java

@github-actions
Copy link

github-actions bot commented Feb 27, 2023

Revision: 60b82be

Submitted crossbow builds: ursacomputing/crossbow @ actions-a0bd129461

Task Status
java-jars Github Actions
verify-rc-source-java-linux-almalinux-8-amd64 Github Actions
verify-rc-source-java-linux-conda-latest-amd64 Github Actions
verify-rc-source-java-linux-ubuntu-18.04-amd64 Github Actions
verify-rc-source-java-linux-ubuntu-20.04-amd64 Github Actions
verify-rc-source-java-linux-ubuntu-22.04-amd64 Github Actions
verify-rc-source-java-macos-amd64 Github Actions

tustvold
tustvold approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the Java codebase, but this change seems consistent with changes in 06f28d2

@lidavidm lidavidm merged commit 25db9c1 into apache:main Feb 27, 2023
@lidavidm lidavidm deleted the gh-34367 branch February 27, 2023 17:23
@ursabot
Copy link

ursabot commented Feb 28, 2023

Benchmark runs are scheduled for baseline = 589a847 and contender = 25db9c1. 25db9c1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.37% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.51%] ursa-i9-9960x
[Failed ⬇️0.13% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 25db9c12 ec2-t3-xlarge-us-east-2
[Finished] 25db9c12 test-mac-arm
[Finished] 25db9c12 ursa-i9-9960x
[Finished] 25db9c12 ursa-thinkcentre-m75q
[Finished] 589a8475 ec2-t3-xlarge-us-east-2
[Failed] 589a8475 test-mac-arm
[Finished] 589a8475 ursa-i9-9960x
[Failed] 589a8475 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
@lidavidm @kou
apacheGH-34367: [Java] Fix build error from sequential merges (apache…
3bf9f7e 
…#34368)

### Rationale for this change

I broke main by merging two PRs in quick succession that unfortunately didn't work together.

### What changes are included in this PR?

Fix the build error.

### Are these changes tested?

N/A

### Are there any user-facing changes?

No, test code only
* Closes: apache#34367

Authored-by: David Li <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tustvold tustvold tustvold approved these changes

Assignees

No one assigned

Labels

Component: Java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Java] Java Integration Test Failures

3 participants

@lidavidm @ursabot @tustvold