Skip to content

GH-33709: [R] Remove suffix argument from semi_join and anti_join#34030

Merged
thisisnic merged 2 commits intoapache:masterfrom
thisisnic:GH-33709-semi_join_sig
Feb 6, 2023
Merged

GH-33709: [R] Remove suffix argument from semi_join and anti_join#34030
thisisnic merged 2 commits intoapache:masterfrom
thisisnic:GH-33709-semi_join_sig

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented Feb 3, 2023 •
edited by github-actions bot
Loading

The function signatures for semi_join() and anti_join() don't match those of dplyr. This PR removes the argument suffix from anti_join() and semi_join(). Is this change necessary/useful or just pedantic? Unsure.

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

paleolimbot
paleolimbot approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a devtools::document() but otherwise looks good!

@thisisnic thisisnic merged commit 32c7130 into apache:master Feb 6, 2023
@ursabot
Copy link

ursabot commented Feb 6, 2023

Benchmark runs are scheduled for baseline = 1aea20b and contender = 32c7130. 32c7130 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.28% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.22% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 32c71306 ec2-t3-xlarge-us-east-2
[Failed] 32c71306 test-mac-arm
[Finished] 32c71306 ursa-i9-9960x
[Finished] 32c71306 ursa-thinkcentre-m75q
[Finished] 1aea20bc ec2-t3-xlarge-us-east-2
[Finished] 1aea20bc test-mac-arm
[Finished] 1aea20bc ursa-i9-9960x
[Finished] 1aea20bc ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paleolimbot paleolimbot paleolimbot approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[R] semi_join and anti_join function signatures in Arrow differ from dplyr

3 participants

@thisisnic @ursabot @paleolimbot