Skip to content

ARROW-2934: [Packaging] Add checksums creation to sign subcommand - #2338

Closed
cpcloud wants to merge 7 commits into
apache:masterfrom
cpcloud:ARROW-2934
Closed

cpcloud wants to merge 7 commits into
apache:masterfrom
cpcloud:ARROW-2934

Conversation

@cpcloud

@cpcloud cpcloud commented Jul 29, 2018 •

Copy link
Copy Markdown
Contributor

cs

@wesm wesm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io

codecov-io commented Jul 29, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #2338 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2338   +/-   ##
=======================================
  Coverage   84.48%   84.48%           
=======================================
  Files         293      293           
  Lines       45160    45160           
=======================================
  Hits        38154    38154           
  Misses       6975     6975           
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd162f5...92c004c. Read the comment docs.

@kszucs

kszucs commented Jul 29, 2018

Copy link
Copy Markdown
Member

LGTM

@cpcloud

cpcloud commented Jul 29, 2018

Copy link
Copy Markdown
Contributor Author

Merging on green

@cpcloud

cpcloud commented Jul 29, 2018

Copy link
Copy Markdown
Contributor Author

Had to change .sig to .asc for gpg signatures in accordance with these ASF guidelines

@kszucs

kszucs commented Jul 29, 2018

Copy link
Copy Markdown
Member

Thanks for the link!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants