ARROW-2721: [C++] Fix ORC and Protocol Buffers link error#2146
Closed
kou wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-2721: [C++] Fix ORC and Protocol Buffers link error#2146kou wants to merge 1 commit intoapache:masterfrom
kou wants to merge 1 commit intoapache:masterfrom
Conversation
It's introduced at 408aa5a by me. Sorry.
Codecov Report
@@ Coverage Diff @@
## master #2146 +/- ##
==========================================
- Coverage 86.42% 86.39% -0.03%
==========================================
Files 242 230 -12
Lines 41536 40644 -892
==========================================
- Hits 35896 35116 -780
+ Misses 5640 5528 -112Continue to review full report at Codecov.
|
Member
|
Thank you for fixing this! I actually ran into this linker error myself when working on the TensorFlow symbol clash issue going on in that other patch. The good news is that revamping the symbols.map in that patch may resolve the problem (making it similar to the symbols.map in PyTorch). I will look in the next 5-7 days if no one beats me to it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's introduced at 408aa5a by me.
Sorry.