ARROW-2691: [Rust] Update code formatting with latest Rust stable#2126
Closed
andygrove wants to merge 16 commits intoapache:masterfrom
andygrove:fix_fmt
Closed
ARROW-2691: [Rust] Update code formatting with latest Rust stable#2126andygrove wants to merge 16 commits intoapache:masterfrom andygrove:fix_fmt
andygrove wants to merge 16 commits intoapache:masterfrom
andygrove:fix_fmt
Conversation
andygrove
changed the title
andygrove
changed the title
andygrove
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2126 +/- ##
==========================================
+ Coverage 86.37% 87.33% +0.95%
==========================================
Files 230 12 -218
Lines 40589 892 -39697
==========================================
- Hits 35059 779 -34280
+ Misses 5530 113 -5417Continue to review full report at Codecov.
|
wesm
approved these changes
Jun 9, 2018
xhochy
approved these changes
Jun 9, 2018
Member
xhochy
left a comment
xhochy
left a comment
There was a problem hiding this comment.
+1, LGTM
Thanks. In the longterm, should we somehow pin the version of rustfmt as we do with clang-format?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.