ARROW-2554: [Python] fix timestamp unit detection from python lists#2118
ARROW-2554: [Python] fix timestamp unit detection from python lists#2118crepererum wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2118 +/- ##
==========================================
- Coverage 86.39% 86.38% -0.02%
==========================================
Files 242 230 -12
Lines 41481 40611 -870
==========================================
- Hits 35838 35080 -758
+ Misses 5643 5531 -112
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Use checked_cast<TimestampType&>(*type) here to avoid increasing the reference counter. (checked_cast is an Arrow-defined cast that evaluates to dynamic_cast in debug builds, otherwise it's a static_cast).
There was a problem hiding this comment.
If you do that, make sure to use const auto& otherwise I believe the copy constructor will still be invoked
There was a problem hiding this comment.
If the scalar type is some other unit (or unitless? can't remember how we're handling that at the moment) then you should raise in an else branch
|
@xhochy ready :) |
4 participants
No description provided.