ARROW-2626: [Python] Add column name to exception message when writing pandas df fails#2075
Closed
louispotok wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-2626: [Python] Add column name to exception message when writing pandas df fails#2075louispotok wants to merge 2 commits intoapache:masterfrom
louispotok wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2075 +/- ##
==========================================
- Coverage 86.33% 86.31% -0.02%
==========================================
Files 242 230 -12
Lines 41101 40217 -884
==========================================
- Hits 35485 34714 -771
+ Misses 5616 5503 -113
Continue to review full report at Codecov.
|
wesm
changed the title
wesm
approved these changes
Jun 12, 2018
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
+1, thank you. From looking at python/numpy_to_arrow.cc, we are returning both TypeError and Invalid for various failure modes. I will open a JIRA about looking through these errors to decide if we are returning the right error types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal is to make debugging easier - it's now possible to see which column failed.
One quick question, I'm not sure if we need to be catching both ArrowInvalid and ArrowTypeError - I think this used to throw ArrowInvalid but now only throws ArrowTypeError. Thoughts?