Skip to content

ARROW-16728: [Python] ParquetDataset to still take legacy code path when old filesystem is passed - #15269

Merged
kou merged 2 commits into
apache:masterfrom
jorisvandenbossche:ARROW-16728-fixup
Jan 9, 2023
Merged

ARROW-16728: [Python] ParquetDataset to still take legacy code path when old filesystem is passed#15269
kou merged 2 commits into
apache:masterfrom
jorisvandenbossche:ARROW-16728-fixup

Conversation

@jorisvandenbossche

@jorisvandenbossche jorisvandenbossche commented Jan 9, 2023

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Jan 9, 2023

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16728

@jorisvandenbossche

jorisvandenbossche commented Jan 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Addressing #14052 (comment)

@jorisvandenbossche

jorisvandenbossche commented Jan 9, 2023

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit -g python

@jorisvandenbossche jorisvandenbossche mentioned this pull request Jan 9, 2023
Merged
@github-actions

github-actions Bot commented Jan 9, 2023

Copy link
Copy Markdown

Revision: 27ae334

Submitted crossbow builds: ursacomputing/crossbow @ actions-7f38dbea67

Task Status
test-conda-python-3.10 Github Actions
test-conda-python-3.11 Github Actions
test-conda-python-3.7 Github Actions
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-hdfs-3.2.1 Github Actions
test-conda-python-3.7-pandas-1.0 Github Actions
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.7-spark-v3.1.2 Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-hypothesis Github Actions
test-conda-python-3.8-pandas-latest Github Actions
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.8-spark-v3.2.0 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-dask-latest Github Actions
test-conda-python-3.9-dask-upstream_devel Github Actions
test-conda-python-3.9-pandas-upstream_devel Github Actions
test-conda-python-3.9-spark-master Github Actions
test-cuda-python Github Actions
test-debian-11-python-3 Azure
test-fedora-35-python-3 Azure
test-ubuntu-20.04-python-3 Azure

@jorisvandenbossche

jorisvandenbossche commented Jan 9, 2023

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit -g python

@github-actions

github-actions Bot commented Jan 9, 2023

Copy link
Copy Markdown

Revision: be2ffb4

Submitted crossbow builds: ursacomputing/crossbow @ actions-92c88488f1

Task Status
test-conda-python-3.10 Github Actions
test-conda-python-3.11 Github Actions
test-conda-python-3.7 Github Actions
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-hdfs-3.2.1 Github Actions
test-conda-python-3.7-pandas-1.0 Github Actions
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.7-spark-v3.1.2 Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-hypothesis Github Actions
test-conda-python-3.8-pandas-latest Github Actions
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.8-spark-v3.2.0 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-dask-latest Github Actions
test-conda-python-3.9-dask-upstream_devel Github Actions
test-conda-python-3.9-pandas-upstream_devel Github Actions
test-conda-python-3.9-spark-master Github Actions
test-cuda-python Github Actions
test-debian-11-python-3 Azure
test-fedora-35-python-3 Azure
test-ubuntu-20.04-python-3 Azure

kou
kou approved these changes Jan 9, 2023
View reviewed changes

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks!

@kou
kou merged commit 5f3df12 into apache:master Jan 9, 2023
@jorisvandenbossche
jorisvandenbossche deleted the ARROW-16728-fixup branch January 9, 2023 13:51
@ursabot

ursabot commented Jan 10, 2023

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 0121ae7 and contender = 5f3df12. 5f3df12 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.91% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.07% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 5f3df125 ec2-t3-xlarge-us-east-2
[Finished] 5f3df125 test-mac-arm
[Finished] 5f3df125 ursa-i9-9960x
[Finished] 5f3df125 ursa-thinkcentre-m75q
[Finished] 0121ae73 ec2-t3-xlarge-us-east-2
[Finished] 0121ae73 test-mac-arm
[Finished] 0121ae73 ursa-i9-9960x
[Finished] 0121ae73 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this pull request Jan 10, 2023
@jorisvandenbossche @EpsilonPrime
ARROW-16728: [Python] ParquetDataset to still take legacy code path w…
cc48fe0 
…hen old filesystem is passed (apache#15269)

Authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@asfimport asfimport mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

Assignees

No one assigned

Labels

Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jorisvandenbossche @ursabot @kou