MINOR: [Go][CI] Increase workflow timeout due to benchmarking#14921
MINOR: [Go][CI] Increase workflow timeout due to benchmarking#14921zeroshade merged 1 commit intoapache:masterfrom
Conversation
|
Uh, we run benchmarks on CI builds? |
|
@pitrou via conbench, @jonkeane and @alistaire47 can explain more as it was their request to set it up this way. |
|
But are trusting GH runners to provide stable runtimes? |
|
Jon's on PTO at the moment, but AFAIK this setup is a fairly temporary state of affairs. I'm in the middle of a larger project to rearrange how we run benchmarks, and hopefully before too long it won't be too hard to run this through arrow-benchmarks-ci like the rest of the benchmarks (though we'll have to figure out what machines make sense given capacity on that side). Not sure exactly when that will be ready, but likely Jan-Feb. And this is all based on my assumptions; if Jon says otherwise, I defer to them. |
assignUser
left a comment
assignUser
left a comment
There was a problem hiding this comment.
Should be ok with the current CI capacity 👍
|
It seems that this doesn't solve the problem: https://github.com/apache/arrow/actions/runs/3689554605 |
|
Benchmark runs are scheduled for baseline = 56cf063 and contender = 624efd0. 624efd0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
6 participants
With the added benchmarking running, the Go workflows occasionally take longer than the 30 minutes, so we need to increase the workflow timeout time.