Skip to content

MINOR: [Java] ArrowBuf#setOne should have int64 params#14911

Merged
lidavidm merged 2 commits intoapache:masterfrom
gf2121:minor_fix
Dec 12, 2022
Merged

MINOR: [Java] ArrowBuf#setOne should have int64 params#14911
lidavidm merged 2 commits intoapache:masterfrom
gf2121:minor_fix

Conversation

@gf2121
Copy link
Contributor

@gf2121 gf2121 commented Dec 11, 2022

ArrowBuf#setOne should have int64 params

@gf2121 gf2121 changed the title MINOR: ArrowBuf#setOne should have int64 params MINOR: [Java] ArrowBuf#setOne should have int64 params Dec 11, 2022
lidavidm
lidavidm reviewed Dec 12, 2022
View reviewed changes
java/memory/memory-core/src/main/java/org/apache/arrow/memory/ArrowBuf.java
* @return this ArrowBuf
*/
public ArrowBuf setOne(int index, int length) {
public ArrowBuf setOne(long index, long length) {
Copy link
Member

@lidavidm lidavidm Dec 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we leave behind an @Deprecated version of this with the original signature, then remove it in v12?

@lidavidm lidavidm merged commit 6f86fce into apache:master Dec 12, 2022
@ursabot
Copy link

ursabot commented Dec 13, 2022

Benchmark runs are scheduled for baseline = 34672cb and contender = 6f86fce. 6f86fce is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0% ⚠️ Contender and baseline run contexts do not match] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 6f86fce8 ec2-t3-xlarge-us-east-2
[Finished] 6f86fce8 test-mac-arm
[Finished] 6f86fce8 ursa-i9-9960x
[Finished] 6f86fce8 ursa-thinkcentre-m75q
[Finished] 34672cb2 ec2-t3-xlarge-us-east-2
[Finished] 34672cb2 test-mac-arm
[Finished] 34672cb2 ursa-i9-9960x
[Finished] 34672cb2 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
@gf2121 @kou
MINOR: [Java] ArrowBuf#setOne should have int64 params (apache#14911)
1c47199 
`ArrowBuf#setOne` should have int64 params

Authored-by: 郭峰 <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees

No one assigned

Labels

Component: Java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gf2121 @ursabot @lidavidm