Skip to content

GH-14855: [C++] Support importing zero-case unions#14857

Merged
pitrou merged 2 commits intoapache:masterfrom
lidavidm:gh-14855
Dec 12, 2022
Merged

GH-14855: [C++] Support importing zero-case unions#14857
pitrou merged 2 commits intoapache:masterfrom
lidavidm:gh-14855

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Dec 6, 2022 •
edited by github-actions bot
Loading

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

@lidavidm lidavidm marked this pull request as ready for review December 6, 2022 22:20
pitrou
pitrou requested changes Dec 12, 2022
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In addition to the schema tests, can you add similar tests for array import/export (or roundtrip)?

@lidavidm
Copy link
Member Author

lidavidm commented Dec 12, 2022

Done.

pitrou
pitrou approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @lidavidm !

@pitrou pitrou merged commit 34672cb into apache:master Dec 12, 2022
@lidavidm lidavidm deleted the gh-14855 branch December 12, 2022 19:14
@ursabot
Copy link

ursabot commented Dec 13, 2022

Benchmark runs are scheduled for baseline = 45d83fe and contender = 34672cb. 34672cb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0% ⚠️ Contender and baseline run contexts do not match] ursa-i9-9960x
[Finished ⬇️0.0% ⬆️0.0% ⚠️ Contender and baseline run contexts do not match] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 34672cb2 ec2-t3-xlarge-us-east-2
[Finished] 34672cb2 test-mac-arm
[Finished] 34672cb2 ursa-i9-9960x
[Finished] 34672cb2 ursa-thinkcentre-m75q
[Finished] 45d83fec ec2-t3-xlarge-us-east-2
[Finished] 45d83fec test-mac-arm
[Finished] 45d83fec ursa-i9-9960x
[Finished] 45d83fec ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++] Zero-case union can't be imported via C Data Interface

3 participants

@lidavidm @ursabot @pitrou