Skip to content

MINOR: [Python] Bump max_line_length = 88#14769

Merged
pitrou merged 1 commit intoapache:masterfrom
milesgranger:MINOR_bump-python-line-length
Dec 12, 2022
Merged

MINOR: [Python] Bump max_line_length = 88#14769
pitrou merged 1 commit intoapache:masterfrom
milesgranger:MINOR_bump-python-line-length

Conversation

@milesgranger
Copy link
Contributor

@milesgranger milesgranger commented Nov 29, 2022

No description provided.

pitrou
pitrou approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @jorisvandenbossche Should this be merged?

@pitrou pitrou merged commit 3e2a224 into apache:master Dec 12, 2022
@milesgranger milesgranger deleted the MINOR_bump-python-line-length branch December 12, 2022 19:48
@ursabot
Copy link

ursabot commented Dec 14, 2022

Benchmark runs are scheduled for baseline = c7eddff and contender = 3e2a224. 3e2a224 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.2% ⬆️0.2%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 3e2a2242 ec2-t3-xlarge-us-east-2
[Finished] 3e2a2242 test-mac-arm
[Finished] 3e2a2242 ursa-i9-9960x
[Finished] 3e2a2242 ursa-thinkcentre-m75q
[Finished] c7eddff9 ec2-t3-xlarge-us-east-2
[Finished] c7eddff9 test-mac-arm
[Finished] c7eddff9 ursa-i9-9960x
[Finished] c7eddff9 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@jorisvandenbossche jorisvandenbossche mentioned this pull request Dec 22, 2022
Merged
raulcd pushed a commit that referenced this pull request Jan 16, 2023
@jorisvandenbossche @assignUser
MINOR: [Python] Fix pre-commit and archery flake8 to honor pyarrow co…
2f8e2b2 
…nfig (#15067)

#14769 changed the flake8 config for pyarrow to raise max line length to 88, but our linting checks didn't actually follow that. 

Lead-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Jacob Wujciak-Jens <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

@jorisvandenbossche jorisvandenbossche Awaiting requested review from jorisvandenbossche

Assignees

No one assigned

Labels

Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@milesgranger @ursabot @pitrou