ARROW-18247: [JS] fix: RangeError crash in Vector.toArray()#14587
ARROW-18247: [JS] fix: RangeError crash in Vector.toArray()#14587domoritz merged 5 commits intoapache:masterfrom
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
|
|
domoritz
left a comment
There was a problem hiding this comment.
Thank you for the pull request. Please add a unit test so we make sure this issue doesn't surface again.
This fixes a bug which happens when a Vector has been created with multiple data blobs and at least one of them has been padded.
1da239a to
8db45ee
Compare
Co-authored-by: Paul Taylor <[email protected]>
Co-authored-by: Paul Taylor <[email protected]>
Co-authored-by: Paul Taylor <[email protected]>
|
@domoritz fixed. 🤦 I did some last minute cleanup and added this test to show exactly the key condition for this bug but ended up with a failing test. Sorry about this. |

This fixes a bug which happens when a Vector has been created with multiple data blobs and at least one of them has been padded.
See https://observablehq.com/d/14488c116b338560 for a reproduction of the error and more details.