Skip to content

ARROW-18083: [C++] Bump vendored zlib version#14446

Merged
kou merged 1 commit intoapache:masterfrom
pitrou:ARROW-18083-bump-zlib
Oct 19, 2022
Merged

ARROW-18083: [C++] Bump vendored zlib version#14446
kou merged 1 commit intoapache:masterfrom
pitrou:ARROW-18083-bump-zlib

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Oct 18, 2022

This new version includes a security fix.

@pitrou
ARROW-18083: [C++] Bump vendored zlib version
a5e6025 
This new version includes a security fix.
@pitrou pitrou marked this pull request as ready for review October 18, 2022 08:15
@pitrou
Copy link
Member Author

pitrou commented Oct 18, 2022

Revision: a5e6025

Submitted crossbow builds: ursacomputing/crossbow @ ARROW-18083-bump-zlib-0

Task Status
almalinux-8-amd64 Github Actions
almalinux-8-arm64 Travis CI
almalinux-9-amd64 Github Actions
almalinux-9-arm64 Travis CI
amazon-linux-2-amd64 Github Actions
amazon-linux-2-arm64 Travis CI
centos-7-amd64 Github Actions
centos-8-stream-amd64 Github Actions
centos-8-stream-arm64 Travis CI
centos-9-stream-amd64 Github Actions
centos-9-stream-arm64 Travis CI
conan-maximum Github Actions
conan-minimum Github Actions
conda-clean Azure
conda-linux-gcc-py310-arm64 Azure
conda-linux-gcc-py310-cpu Azure
conda-linux-gcc-py310-cuda Azure
conda-linux-gcc-py310-ppc64le Azure
conda-linux-gcc-py37-arm64 Azure
conda-linux-gcc-py37-cpu-r40 Azure
conda-linux-gcc-py37-cpu-r41 Azure
conda-linux-gcc-py37-cuda Azure
conda-linux-gcc-py37-ppc64le Azure
conda-linux-gcc-py38-arm64 Azure
conda-linux-gcc-py38-cpu Azure
conda-linux-gcc-py38-cuda Azure
conda-linux-gcc-py38-ppc64le Azure
conda-linux-gcc-py39-arm64 Azure
conda-linux-gcc-py39-cpu Azure
conda-linux-gcc-py39-cuda Azure
conda-linux-gcc-py39-ppc64le Azure
conda-osx-arm64-clang-py310 Azure
conda-osx-arm64-clang-py38 Azure
conda-osx-arm64-clang-py39 Azure
conda-osx-clang-py310 Azure
conda-osx-clang-py37-r40 Azure
conda-osx-clang-py37-r41 Azure
conda-osx-clang-py38 Azure
conda-osx-clang-py39 Azure
conda-win-vs2019-py310 Azure
conda-win-vs2019-py37-r40 Azure
conda-win-vs2019-py37-r41 Azure
conda-win-vs2019-py38 Azure
conda-win-vs2019-py39 Azure
debian-bookworm-amd64 Github Actions
debian-bookworm-arm64 Travis CI
debian-bullseye-amd64 Github Actions
debian-bullseye-arm64 Travis CI
example-cpp-minimal-build-static Github Actions
example-cpp-minimal-build-static-system-dependency Github Actions
example-python-minimal-build-fedora-conda Github Actions
example-python-minimal-build-ubuntu-venv Github Actions
homebrew-cpp Github Actions
homebrew-r-autobrew Github Actions
homebrew-r-brew Github Actions
java-jars Github Actions
nuget Github Actions
python-sdist Github Actions
r-binary-packages Github Actions
test-alpine-linux-cpp Github Actions
test-build-cpp-fuzz Github Actions
test-build-vcpkg-win Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-conda-python-3.10 Github Actions
test-conda-python-3.7 Github Actions
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-hdfs-3.2.1 Github Actions
test-conda-python-3.7-pandas-0.24 Github Actions
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.7-spark-v3.1.2 Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-hypothesis Github Actions
test-conda-python-3.8-pandas-latest Github Actions
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.8-spark-v3.2.0 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-dask-latest Github Actions
test-conda-python-3.9-dask-master Github Actions
test-conda-python-3.9-pandas-master Github Actions
test-conda-python-3.9-spark-master Github Actions
test-debian-10-cpp-amd64 Github Actions
test-debian-10-cpp-i386 Github Actions
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-debian-11-go-1.17 Azure
test-debian-11-python-3 Azure
test-debian-c-glib Github Actions
test-debian-ruby Github Actions
test-fedora-35-cpp Github Actions
test-fedora-35-python-3 Azure
test-fedora-r-clang-sanitizer Azure
test-r-arrow-backwards-compatibility Github Actions
test-r-depsource-bundled Azure
test-r-depsource-system Github Actions
test-r-dev-duckdb Github Actions
test-r-devdocs Github Actions
test-r-gcc-11 Github Actions
test-r-gcc-12 Github Actions
test-r-install-local Github Actions
test-r-install-local-minsizerel Github Actions
test-r-linux-as-cran Github Actions
test-r-linux-rchk Github Actions
test-r-linux-valgrind Azure
test-r-minimal-build Azure
test-r-offline-maximal Github Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-debian-gcc-release-custom-ccache Azure
test-r-rhub-ubuntu-gcc-release-latest Azure
test-r-rocker-r-base-latest Azure
test-r-rstudio-r-base-4.1-opensuse153 Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8 Azure
test-r-rstudio-r-base-4.2-focal Azure
test-r-ubuntu-22.04 Github Actions
test-r-versions Github Actions
test-skyhook-integration Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-18.04-r-sanitizer Azure
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-17 Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-20.04-python-3 Azure
test-ubuntu-22.04-cpp Github Actions
test-ubuntu-c-glib Github Actions
test-ubuntu-default-docs Azure
test-ubuntu-ruby Github Actions
ubuntu-bionic-amd64 Github Actions
ubuntu-bionic-arm64 Travis CI
ubuntu-focal-amd64 Github Actions
ubuntu-focal-arm64 Travis CI
ubuntu-jammy-amd64 Github Actions
ubuntu-jammy-arm64 Travis CI
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp310-universal2 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions
wheel-macos-mojave-cp310-amd64 Github Actions
wheel-macos-mojave-cp37-amd64 Github Actions
wheel-macos-mojave-cp38-amd64 Github Actions
wheel-macos-mojave-cp39-amd64 Github Actions
wheel-manylinux2014-cp310-amd64 Github Actions
wheel-manylinux2014-cp310-arm64 Travis CI
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 Travis CI
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 Travis CI
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 Travis CI
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@pitrou pitrou requested a review from kou October 18, 2022 08:21
@pitrou
Copy link
Member Author

pitrou commented Oct 18, 2022

@raulcd @kou Something weird is happening with the Github Actions hyperlinks in the Crossbow HTML report above.

@pitrou
Copy link
Member Author

pitrou commented Oct 18, 2022

For example the link to conan-maximum should be https://github.com/ursacomputing/crossbow/actions/runs/3271725954/jobs/5381859092, not https://github.com/ursacomputing/crossbow//tree/ARROW-18083-bump-zlib-0-github-conan-maximum

@github-actions
Copy link

github-actions bot commented Oct 18, 2022

https://issues.apache.org/jira/browse/ARROW-18083

@raulcd
Copy link
Member

raulcd commented Oct 18, 2022

For example the link to conan-maximum should be https://github.com/ursacomputing/crossbow/actions/runs/3271725954/jobs/5381859092, not https://github.com/ursacomputing/crossbow//tree/ARROW-18083-bump-zlib-0-github-conan-maximum

There has been several issues following this ticket:
1e481b5
We added a wait time but sometimes some actions take quite a lot of time to start, so we use the default branch instead of the run URL. I am going to open a ticket, if the individual run is not found we probably should use the original URL we used to use, in your example would be:
https://github.com/ursacomputing/crossbow/actions?query=branch:ARROW-18083-bump-zlib-0-github-conan-maximum

@raulcd
Copy link
Member

raulcd commented Oct 18, 2022

I've created https://issues.apache.org/jira/browse/ARROW-18085 to track the issue

@pitrou
Copy link
Member Author

pitrou commented Oct 18, 2022

The MinGW failures here are weird but I doubt they are related:


The following tests FAILED:
	  1 - arrow-array-test (Exit code 0xc0000139
)
	  2 - arrow-buffer-test (Exit code 0xc0000139
)
	  3 - arrow-extension-type-test (Exit code 0xc0000139
)
	  4 - arrow-misc-test (Exit code 0xc0000139
)

[etc.]

Have we already seen them?

@raulcd
Copy link
Member

raulcd commented Oct 18, 2022

Have we already seen them?

They seem to be happening in other PRs:
#14444
Example:
https://github.com/apache/arrow/actions/runs/3271398126/jobs/5381140450

kou
kou approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

All failures are unrelated to this.

@kou kou merged commit 3ff3f6d into apache:master Oct 19, 2022
@pitrou pitrou deleted the ARROW-18083-bump-zlib branch October 19, 2022 08:56
kou pushed a commit that referenced this pull request Oct 20, 2022
@pitrou @kou
ARROW-18083: [C++] Bump vendored zlib version (#14446)
a735316 
This new version includes a security fix.

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@asfimport asfimport mentioned this pull request Oct 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou @raulcd @kou