ARROW-17160: [C++] Create a base directory for PyArrow CPP header files#14275
ARROW-17160: [C++] Create a base directory for PyArrow CPP header files#14275jorisvandenbossche merged 6 commits intoapache:masterfrom
Conversation
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
There is still the question about moving the include paths from "arrow/python/.." to "pyarrow/.." (and how to provide some transition path for this), but assuming the current status of exposing those as "arrow/python/.." (which seems the safe assumption for 10.0), this seems like a good change to use those paths in the code and headers itself.
I suggest we try to move the include paths from |
|
Could you create a separate JIRA issue for it? |
|
I am sorry for rerunning this travis ci job at https://app.travis-ci.com/github/apache/arrow/builds/256419696 while the job was already succeeded. |
No problem at all =) |
|
@kou Do you have any other concerns? |
|
No. |
|
I will merge later today, if there is no objection =) |
|
The Python failure is one of the flaky dataset tests |
|
Thanks @AlenkaF ! |
|
Benchmark runs are scheduled for baseline = d8f3946 and contender = 21dbf4a. 21dbf4a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…moving pyarrow C++ code (#14311) Keeping it as draft until #14275 is resolved and final structure is decided. Authored-by: Alenka Frim <[email protected]> Signed-off-by: Alenka Frim <[email protected]>
6 participants
This PR is a follow-up of #13311 where it was decided to change the base directory for PyArrow C++ headers to avoid top level inclusions. See #13311 (comment)