Repository navigation
ARROW-17818: [R] Skip duckdb test that is failing until the issue is resolved - #14209
Conversation
paleolimbot
changed the title
| skip_if_not(packageVersion("duckdb") > "0.5.0") | ||
| # ARROW-17643, ARROW-17818: A change in duckdb 0.5.0 caused this test to fail | ||
| # TODO: ARROW-17809 Follow up with the latest duckdb release to solve the issue | ||
| skip("ARROW-17818: Latest DuckDB causes this test to fail") |
There was a problem hiding this comment.
I haven't been following this particular bug too closely so don't know this off the top of my head: is this the only test block that fails? And if so: does it fail during cleanup or during the query?
This is a pretty low-risk test to generically skip if this is the only test that is an issue since we have basically the same query without autocleanup below.
There was a problem hiding this comment.
Yes, it's just this one. A user may run into this if they try a dplyr left_join() of their own, but it's not a crash or a corruption of data, just a mysterious error.
There was a problem hiding this comment.
Also, given that none of us can replicate it on normal computers, it's unlikely to surface in real life (still good to solve, just improbable).
There was a problem hiding this comment.
That sounds a bit dismissive. Just because this particular test doesn't replicate it doesn't mean it may not occur more frequently with another sequence of operations.
There was a problem hiding this comment.
Yes, sorry, it's definitely a problem, and may well be a problem with Arrow/R or Arrow/C++ that the change in DuckDB surfaced. There's an open PR + an open JIRA to make sure this doesn't get forgotten about.
|
|
|
|
|
Benchmark runs are scheduled for baseline = 36928ec and contender = 53b19a9. 53b19a9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…resolved (apache#14209) This just skips the test to stop it from obscuring other failures until we diagnose it properly (ARROW-17818). Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
This just skips the test to stop it from obscuring other failures until we diagnose it properly (ARROW-17818).