ARROW-1909: [C++] Enables building with benchmarks on windows#1406
Closed
seibs wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-1909: [C++] Enables building with benchmarks on windows#1406seibs wants to merge 1 commit intoapache:masterfrom
seibs wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Sweet, thank you. I will take this for a spin when I get a chance and merge if no issues |
Contributor
Author
Member
|
I added |
Contributor
Author
|
Awesome, thanks @wesm - once this is merged I'll rebase my other open pull request. |
Use int64 literal Change-Id: I96ab9edf10aebf2ea26170c90450e7341687e6d3 Revert int64->int because gbenchmark does not allow 64-bit integers in Args
Member
|
Turns out the the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes were necessary to compile on Windows with "-DARROW_BUILD_BENCHMARKS=ON". I added Shwlapi based on google/benchmark#202.