Skip to content

ARROW-15277: [C++][Python] Use ChunkedArray::Make for chunked_array - #13950

Merged
pitrou merged 9 commits into
apache:masterfrom
milesgranger:ARROW-15277_Use-Make-to-create-ChunkedArray
Aug 25, 2022
Merged

ARROW-15277: [C++][Python] Use ChunkedArray::Make for chunked_array#13950
pitrou merged 9 commits into
apache:masterfrom
milesgranger:ARROW-15277_Use-Make-to-create-ChunkedArray

Conversation

@milesgranger

@milesgranger milesgranger commented Aug 23, 2022

Copy link
Copy Markdown
Contributor

Supersedes and will close #12096

ARROW-15277

@github-actions

github-actions Bot commented Aug 23, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-15277

@github-actions

github-actions Bot commented Aug 23, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@milesgranger

milesgranger commented Aug 24, 2022

Copy link
Copy Markdown
Contributor Author

@pitrou I believe this is ready for a review.

pitrou
pitrou reviewed Aug 24, 2022
View reviewed changes
Comment thread python/pyarrow/tests/test_table.py Outdated

@pitrou pitrou Aug 24, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... interesting. I would be in favor of changing the C++ side to return TypeError instead. Would you like to do that in this PR?

pitrou
pitrou reviewed Aug 24, 2022
View reviewed changes
Comment thread python/pyarrow/tests/test_table.py Outdated

@pitrou pitrou Aug 24, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same)

@milesgranger milesgranger changed the title ARROW-15277: [Python] Use ChunkedArray::Make for chunked_array ARROW-15277: [C++][Python] Use ChunkedArray::Make for chunked_array Aug 24, 2022
@milesgranger

milesgranger commented Aug 25, 2022

Copy link
Copy Markdown
Contributor Author

I don't think the R / AMD64 Windows R 3.6 RTools 35 failure is related...

@pitrou

pitrou commented Aug 25, 2022

Copy link
Copy Markdown
Member

Indeed, it isn't.

@pitrou

pitrou commented Aug 25, 2022

Copy link
Copy Markdown
Member

Rebased and a nit.

pitrou
pitrou approved these changes Aug 25, 2022
View reviewed changes

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @milesgranger !

@pitrou

pitrou commented Aug 25, 2022

Copy link
Copy Markdown
Member

Python CI was successful here: https://github.com/milesgranger/arrow/actions/runs/2924730791

@pitrou
pitrou merged commit dd0988b into apache:master Aug 25, 2022
@milesgranger
milesgranger deleted the ARROW-15277_Use-Make-to-create-ChunkedArray branch August 25, 2022 08:54
@ursabot

ursabot commented Aug 25, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 897c186 and contender = dd0988b. dd0988b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.58% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.39% ⬆️0.07%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] dd0988b4 ec2-t3-xlarge-us-east-2
[Failed] dd0988b4 test-mac-arm
[Failed] dd0988b4 ursa-i9-9960x
[Finished] dd0988b4 ursa-thinkcentre-m75q
[Finished] 897c186f ec2-t3-xlarge-us-east-2
[Failed] 897c186f test-mac-arm
[Failed] 897c186f ursa-i9-9960x
[Finished] 897c186f ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@milesgranger @edponce
@pitrou @zagto
ARROW-15277: [C++][Python] Use ChunkedArray::Make for chunked_array (a…
941f069 
…pache#13950)

Supersedes and will close apache#12096 

[ARROW-15277](https://issues.apache.org/jira/browse/ARROW-15277)

Lead-authored-by: Miles Granger <[email protected]>
Co-authored-by: Eduardo Ponce <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

Component: C++ Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@milesgranger @pitrou @ursabot @edponce