Repository navigation
MINOR: [C++] Fix StringFormatter type error in localfs_benchmark - #13932
Conversation
since size_t is passed as the first argument to the StringFormatter, it needs to be templated with DoubleType instead of Int32Type
had a moment of confusion and used the wrong type
the StringFormatter was used in benchmark setup code and only did a single append. Since it is not part of the code benchmarked, this commit simplifies by removing the formatter altogether.
since the StringFormatter was removed, formatting.h does not need to be included anymore
|
@github-actions autotune |
|
oops! hopefully that fixes it |
|
AppVeyor failure is unrelated. |
|
Benchmark runs are scheduled for baseline = d53bce2 and contender = f93ba4d. f93ba4d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…che#13932) since size_t is passed as the first argument to the StringFormatter, it needs to be templated with Int64Type instead of Int32Type Lead-authored-by: Aldrin M <[email protected]> Co-authored-by: Aldrin Montana <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
since size_t is passed as the first argument to the StringFormatter, it
needs to be templated with Int64Type instead of Int32Type