Skip to content

ARROW-17456: [Go] Mark the compute module as a separate sub-module - #13910

Merged
zeroshade merged 5 commits into
apache:masterfrom
zeroshade:arrow-17456-computemodule
Aug 18, 2022
Merged

zeroshade merged 5 commits into
apache:masterfrom
zeroshade:arrow-17456-computemodule

Conversation

@zeroshade

Copy link
Copy Markdown
Member

I noticed looking at pkg.go.dev that there really isn't anyone who is using the existing compute module, which makes sense since it isn't really finished and only provides limited utility currently.

This change will mark the compute module as a separate sub-module inside of the arrow module, allowing us to use go1.18 in this new code without forcing anyone who isn't using the compute module to upgrade. That way I can leverage the generics when writing the new compute code where appropriate.

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@zeroshade
zeroshade force-pushed the arrow-17456-computemodule branch from 6a14b64 to 8942d85 Compare August 17, 2022 22:44
@zeroshade
zeroshade merged commit 3615d7f into apache:master Aug 18, 2022
@zeroshade
zeroshade deleted the arrow-17456-computemodule branch August 18, 2022 14:37
@ursabot

ursabot commented Aug 18, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = b3a29f5 and contender = 3615d7f. 3615d7f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.68% ⬆️0.07%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.57% ⬆️0.68%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 3615d7f5 ec2-t3-xlarge-us-east-2
[Failed] 3615d7f5 test-mac-arm
[Failed] 3615d7f5 ursa-i9-9960x
[Finished] 3615d7f5 ursa-thinkcentre-m75q
[Finished] b3a29f5f ec2-t3-xlarge-us-east-2
[Finished] b3a29f5f test-mac-arm
[Failed] b3a29f5f ursa-i9-9960x
[Finished] b3a29f5f ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
…pache#13910)

I noticed looking at pkg.go.dev that there really isn't anyone who is using the existing `compute` module, which makes sense since it isn't really finished and only provides limited utility currently.

This change will mark the `compute` module as a separate sub-module inside of the `arrow` module, allowing us to use `go1.18` in this new code without forcing anyone who *isn't* using the compute module to upgrade. That way I can leverage the generics when writing the new compute code where appropriate.

Authored-by: Matt Topol <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants