Skip to content

MINOR: Fix docstrings for kleene boolean scalar funcs - #13907

Merged
cyb70289 merged 1 commit into
apache:masterfrom
gforsyth:gil/kleene_doc_fix
Aug 19, 2022
Merged

cyb70289 merged 1 commit into
apache:masterfrom
gforsyth:gil/kleene_doc_fix

Conversation

@gforsyth

Copy link
Copy Markdown
Contributor

It looks like the entries in the truth tables were copy-pasted and the
results were updated to match the function, but not the operator.

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@gforsyth gforsyth changed the title [MINOR] Fix docstrings for kleene boolean scalar funcs MINOR: Fix docstrings for kleene boolean scalar funcs Aug 17, 2022
It looks like the entries in the truth tables were copy-pasted and the
_results_ were updated to match the function, but not the operator.
@gforsyth
gforsyth force-pushed the gil/kleene_doc_fix branch from df3be84 to 2dc7591 Compare August 18, 2022 13:55
@cyb70289
cyb70289 merged commit 1a34a07 into apache:master Aug 19, 2022
@cyb70289

Copy link
Copy Markdown
Contributor

Thanks @gforsyth !

@ursabot

ursabot commented Aug 19, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = a1c3d57 and contender = 1a34a07. 1a34a07 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.05% ⬆️0.14%] test-mac-arm
[Failed ⬇️6.58% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.35% ⬆️0.57%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 1a34a078 ec2-t3-xlarge-us-east-2
[Finished] 1a34a078 test-mac-arm
[Failed] 1a34a078 ursa-i9-9960x
[Finished] 1a34a078 ursa-thinkcentre-m75q
[Finished] a1c3d57a ec2-t3-xlarge-us-east-2
[Failed] a1c3d57a test-mac-arm
[Failed] a1c3d57a ursa-i9-9960x
[Finished] a1c3d57a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot

ursabot commented Aug 19, 2022

Copy link
Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
It looks like the entries in the truth tables were copy-pasted and the
_results_ were updated to match the function, but not the operator.

Authored-by: Gil Forsyth <[email protected]>
Signed-off-by: Yibo Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants