Skip to content

ARROW-17430: [Java] ListBinder to bind Arrow List type to DB column - #13906

Merged
lidavidm merged 8 commits into
apache:masterfrom
igor-suhorukov:master
Aug 19, 2022
Merged

ARROW-17430: [Java] ListBinder to bind Arrow List type to DB column #13906
lidavidm merged 8 commits into
apache:masterfrom
igor-suhorukov:master

Conversation

@igor-suhorukov

@igor-suhorukov igor-suhorukov commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

Typical real life Arrow datasets contain List type vectors of primitive type. This PR introduce ListBinder mapping of primitive types lists to java.sql.Types.ARRAY

lidavidm
lidavidm reviewed Aug 17, 2022
View reviewed changes

@lidavidm lidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but a question about the empty-list case.

Comment thread java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/binder/ListBinder.java Resolved
@github-actions

github-actions Bot commented Aug 17, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17430

@github-actions

github-actions Bot commented Aug 17, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

lidavidm
lidavidm approved these changes Aug 18, 2022
View reviewed changes

@lidavidm lidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - just two questions

Comment thread java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/binder/ListBinder.java Resolved
Comment thread java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/JdbcParameterBinderTest.java Resolved
@lidavidm
lidavidm merged commit b11bc50 into apache:master Aug 19, 2022
@ursabot

ursabot commented Aug 19, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 1a34a07 and contender = b11bc50. b11bc50 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.27% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.82% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.46% ⬆️0.14%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] b11bc505 ec2-t3-xlarge-us-east-2
[Failed] b11bc505 test-mac-arm
[Failed] b11bc505 ursa-i9-9960x
[Finished] b11bc505 ursa-thinkcentre-m75q
[Finished] 1a34a078 ec2-t3-xlarge-us-east-2
[Finished] 1a34a078 test-mac-arm
[Failed] 1a34a078 ursa-i9-9960x
[Finished] 1a34a078 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot

ursabot commented Aug 19, 2022

Copy link
Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@igor-suhorukov igor-suhorukov mentioned this pull request Aug 24, 2022
Closed
zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@igor-suhorukov @zagto
ARROW-17430: [Java] ListBinder to bind Arrow List type to DB column (a…
eaca726 
…pache#13906)

Typical real life Arrow datasets contain List type vectors of primitive type. This PR introduce ListBinder mapping of primitive types lists to java.sql.Types.ARRAY

Lead-authored-by: Igor Suhorukov <[email protected]>
Co-authored-by: igor.suhorukov <[email protected]>
Signed-off-by: David Li <[email protected]>
@asfimport asfimport mentioned this pull request Aug 19, 2022
Closed
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
@igor-suhorukov @kou
ARROW-17430: [Java] ListBinder to bind Arrow List type to DB column (a…
7969c82 
…pache#13906)

Typical real life Arrow datasets contain List type vectors of primitive type. This PR introduce ListBinder mapping of primitive types lists to java.sql.Types.ARRAY

Lead-authored-by: Igor Suhorukov <[email protected]>
Co-authored-by: igor.suhorukov <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees

No one assigned

Labels

Component: Java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igor-suhorukov @ursabot @lidavidm