Repository navigation
ARROW-17254: [C++][Go][Java][FlightRPC] Implement and test Flight SQL GetSchema - #13898
Conversation
|
I expect Go will fail, need to fix that… |
lidavidm
changed the title
lidavidm
changed the title
|
@zeroshade I implemented the GetSchema methods for Go here as well (the original PRs didn't implement them fully, so this PR is to rectify that) @jduo I noticed GetSchema is in the protos but not the implementations; this rectifies that (I expect these methods won't see much use, but might as well) |
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
@lidavidm Thanks! I didn't remember seeing those GetSchema methods anywhere otherwise I would have implemented them the first time around haha.
The Go changes look good from my end, i'm glad you were able to pick it up easily :)
|
Thankfully Go is straightforward! And yeah, they're in the spec and in Java, but got omitted from C++ (whoops) |
|
CI failures are unrelated or already tracked, merging |
|
Benchmark runs are scheduled for baseline = 3615d7f and contender = bc52f9f. bc52f9f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
… GetSchema (apache#13898) Consistently implements and tests the GetSchema method in Flight SQL. Builds on apache#13897. Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
… GetSchema (apache#13898) Consistently implements and tests the GetSchema method in Flight SQL. Builds on apache#13897. Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
Consistently implements and tests the GetSchema method in Flight SQL.
Builds on #13897.