Repository navigation
ARROW-17423: [CI][C++] Fix building CUDA docker images - #13896
Conversation
|
cc @assignUser |
|
|
assignUser
left a comment
assignUser
left a comment
There was a problem hiding this comment.
Thanks for taking this on. Looks good with a minor change to rsplit. We should test it with some windows and linux jobs.
There was a problem hiding this comment.
I assume this is to reduce build times and focus this on CUDA? 👍 Good idea!
|
@kkraus14 Would you like to take a quick look? |
There was a problem hiding this comment.
It may make sense to pick the oldest supported version here instead of this so that someone doesn't accidentally use a feature introduced in a newer driver version and allow it to slip through CI.
There was a problem hiding this comment.
That would seem to be 11.0.3 for Ubuntu 20.04. Does it make sense @kkraus14 ?
(note that this variable will have to be overriden depending on the Ubuntu version selected, anyway)
There was a problem hiding this comment.
For Ubuntu 20.04 that makes sense, if we could use 18.04 I would suggest going with 10.0 instead.
I would hope that everyone is using a 11.0+ driver today though.
* Update the CUDA runtime version as CUDA 9.1 images are not available anymore * Fix passing child command arguments to "docker run" Checked locally under a Ubuntu 20.04 host with: ``` UBUNTU=18.04 archery --debug docker run ubuntu-cuda-cpp UBUNTU=20.04 archery --debug docker run ubuntu-cuda-cpp ```
ccaad19 to
a4e051a
Compare
|
Benchmark runs are scheduled for baseline = 050876c and contender = f6127fc. f6127fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
* Update the CUDA runtime version as CUDA 9.1 images are not available anymore * Fix passing child command arguments to "docker run" Checked locally under a Ubuntu 20.04 host with: ``` UBUNTU=18.04 archery --debug docker run ubuntu-cuda-cpp UBUNTU=20.04 archery --debug docker run ubuntu-cuda-cpp ``` Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Checked locally under a Ubuntu 20.04 host with: